loosen id tag expiration constraints (Closes #48) #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reason: until now, we always used current time + some hours (set in UI) for id tag expiration, regardless of an expiry date the database had for this id tag. the idea behind was to better control two possible situations: - no expiry date: set an explicit one to prevent the station caching it, such that after some time, it _has_ to ask Steve. - expiry date too far in the future: since business rules, contracts, conditions and therefore expiration of id tags might change, we wanted to prevent the stations from storing id tags for too long in the white list. both of these ideas resulted from the thinking that Steve is the single point of truth and that we did not trust charging station implementations. therefore, we always preferred a charging station asking us frequently about the id tag status. with this commit, this constraint is loosened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reason: until now, we always used current time + some hours (set in UI)
for id tag expiration, regardless of an expiry date the database had
for this id tag. the idea behind was to better control two possible
situations:
such that after some time, it has to ask Steve.
conditions and therefore expiration of id tags might change, we wanted
to prevent the stations from storing id tags for too long in the white
list.
both of these ideas resulted from the thinking that Steve is the single
point of truth and that we did not trust charging station implementations.
therefore, we always preferred a charging station asking us frequently
about the id tag status. with this commit, this constraint is loosened.