Skip to content

Improved TimeUtils#7

Merged
jasonlessenich merged 1 commit intomainfrom
andrew/time_fix
Jun 1, 2021
Merged

Improved TimeUtils#7
jasonlessenich merged 1 commit intomainfrom
andrew/time_fix

Conversation

@andrewlalis
Copy link
Contributor

Improves the formatting of durations so that they don't look scuffed, like "1 years, 187 days" is not proper English.

I also added a unit test for it, and added testing to the automatic github action thingy.

@andrewlalis andrewlalis added the bug fix Addresses a bug. label Jun 1, 2021
@jasonlessenich jasonlessenich merged commit cfaeb78 into main Jun 1, 2021
@andrewlalis andrewlalis deleted the andrew/time_fix branch June 1, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix Addresses a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants