proper message instead of internal server error, remove unnecessary data#453
Merged
MoonTM-GIT merged 3 commits intoJava-Discord:mainfrom Nov 6, 2023
Merged
proper message instead of internal server error, remove unnecessary data#453MoonTM-GIT merged 3 commits intoJava-Discord:mainfrom
MoonTM-GIT merged 3 commits intoJava-Discord:mainfrom
Conversation
jasonlessenich
approved these changes
Oct 25, 2023
MoonTM-GIT
approved these changes
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the user API yields an internal server error when requesting a nonexistent user.
This PR changes it to actually throw an
InvalidEntityIdException(as originally intended) which yields a400response with the error from JDA.Examples:
{"status":"BAD_REQUEST","message":"Cannot fetch user: Unknown User","errors":["Entity should be of type: net.dv8tion.jda.api.entities.User"]}{"status":"BAD_REQUEST","message":"Cannot fetch user: Invalid Form Body","errors":["Entity should be of type: net.dv8tion.jda.api.entities.User"]}Furthermore, it removes preferences from that API since that seems unnecessary.