allow deleting responses of own messages/commands with delete button#446
Merged
jasonlessenich merged 2 commits intoJava-Discord:mainfrom Oct 25, 2023
Merged
Conversation
jasonlessenich
approved these changes
Sep 25, 2023
Member
jasonlessenich
left a comment
jasonlessenich
left a comment
There was a problem hiding this comment.
How was this left unnoticed 💀 thanks for fixing this
Member
Author
|
Since requested in the suggestion, the bot now also includes a (now working) delete button in the message link content message. |
jasonlessenich
approved these changes
Sep 26, 2023
chris-sophos
approved these changes
Sep 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the delete button on component messages like
/format-codeor automated responses (e.g. closing reminders) can only be deleted by staff members due to the bot checking the message sender (which is the bot) instead of the user who originally requested the action.This PR adds a user ID to the delete message button in order to allow message deletion by the user who originally requested it/who the message is for.
https://canary.discord.com/channels/648956210850299986/752535909228085348/1155209604909760745