Skip to content

numeric metrics#440

Merged
jasonlessenich merged 1 commit intoJava-Discord:mainfrom
danthe1st:numeric-metrics
Oct 25, 2023
Merged

numeric metrics#440
jasonlessenich merged 1 commit intoJava-Discord:mainfrom
danthe1st:numeric-metrics

Conversation

@danthe1st
Copy link
Member

@danthe1st danthe1st commented Sep 12, 2023

The /guild/{guild_id}/metrics endpoint currently uses Strings for metrics.

This PR changes both the metricConfig and the DTO for that endpoint to use long instead of String.

Important (deploy) note

⚠️ THIS PR CONTAINS A (POTENTIALLY) BACKWARDS INCOMPATIBLE GUILD CONFIG CHANGE! ⚠️

If no elements are stored in the weeklyMessages/activeMembers of the guild config, the guild config cannot be read.
Therefore, the following should be done before deploying

  • Create a backup of the guild config.
  • Ensure that metricsConfig.weeklyMessages and metricsConfig.activeMembers are not empty Strings.

@danthe1st danthe1st requested a review from a team as a code owner September 12, 2023 15:19
Copy link
Contributor

@Pleezon Pleezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasonlessenich
Copy link
Member

Is there anything keeping this from being merged?

@danthe1st
Copy link
Member Author

danthe1st commented Oct 25, 2023

@DynxstyGIT

Is there anything keeping this from being merged?

Not really but care should be taken when deploying in order to not erase the entire config as mentioned in the merge note.

@jasonlessenich jasonlessenich merged commit 588d8c3 into Java-Discord:main Oct 25, 2023
@danthe1st danthe1st deleted the numeric-metrics branch October 25, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants