Merged
Conversation
jasonlessenich
approved these changes
Sep 18, 2023
Pleezon
reviewed
Oct 4, 2023
src/main/java/net/javadiscord/javabot/data/config/guild/MetricsConfig.java
Show resolved
Hide resolved
Member
|
Is there anything keeping this from being merged? |
Member
Author
|
@DynxstyGIT
Not really but care should be taken when deploying in order to not erase the entire config as mentioned in the merge note. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/guild/{guild_id}/metricsendpoint currently usesStrings for metrics.This PR changes both the
metricConfigand the DTO for that endpoint to uselonginstead ofString.Important (deploy) note
If no elements are stored in the
weeklyMessages/activeMembersof the guild config, the guild config cannot be read.Therefore, the following should be done before deploying
metricsConfig.weeklyMessagesandmetricsConfig.activeMembersare not emptyStrings.