Skip to content

Clean Up Slash Command Design#12

Merged
jasonlessenich merged 6 commits intomainfrom
andrew/external_command_data
Jun 17, 2021
Merged

Clean Up Slash Command Design#12
jasonlessenich merged 6 commits intomainfrom
andrew/external_command_data

Conversation

@andrewlalis
Copy link
Contributor

This PR extracts all slash command configuration to a YAML file, and introduces the SlashCommandHandler interface that all command handler classes should implement, instead of a bunch of public static methods.

Beware: some things are broken, like warns, banning someone after their 3rd warn, the shutdown command, etc. All commands from the testing package have been removed, due to dependency on the JDA utilities library which was removed.

There are some //TODO comments in the code which illustrate cases where more work needs to be done.

@jasonlessenich jasonlessenich merged commit 576867d into main Jun 17, 2021
@andrewlalis andrewlalis deleted the andrew/external_command_data branch July 10, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants