Skip to content

fix - required parameter follows optional parameter (php8 compatibility) #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix - required parameter follows optional parameter (php8 compatibility) #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f683f03
fix - required parameter follows optional parameter (php8 compatibility)
majsterkoo Jun 8, 2021
d089d2d
Adding types into constructor parameters
majsterkoo Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Jaspersoft/Client/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ class Client
{
private $restReq;
private $restUrl2;
protected $hostname;
protected $username;
protected $password;
protected $orgId;
protected $hostname;
protected $username;
protected $password;
protected $orgId;
protected $repositoryService;
protected $userService;
protected $organizationService;
Expand All @@ -36,7 +36,7 @@ class Client
protected $logCollectorService;
protected $serverService;

public function __construct($serverUrl, $username, $password, $orgId = null)
public function __construct(string $serverUrl, string $username, string $password, $orgId = null)
{
$this->serverUrl = $serverUrl;
$this->username = $username;
Expand Down
13 changes: 12 additions & 1 deletion src/Jaspersoft/Tool/RESTRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,18 @@ public function multipartRequestSend($url, $expectedCode = 200, $verb = 'PUT_MP'
}


public function sendBinary($url, $expectedCodes = array(200), $body, $contentType, $contentDisposition, $contentDescription, $verb = "POST")
/**
* @param $url
* @param $expectedCodes
* @param $body
* @param $contentType
* @param $contentDisposition
* @param $contentDescription
* @param string $verb
* @return null
* @throws RESTRequestException
*/
public function sendBinary($url, $expectedCodes, $body, $contentType, $contentDisposition, $contentDescription, $verb = "POST")
{
$this->flush();
$this->setUrl($url);
Expand Down