Fix duplicate variable names when multiple middleware return OutgoingMessages#2327
Merged
jeremydmiller merged 1 commit intomainfrom Mar 19, 2026
Merged
Conversation
…Messages The OutgoingMessages variable counter in Chain.AddMiddleware() was reset to 100 on every call, causing duplicate variable names (outgoingMessages101) when multiple middleware methods returned OutgoingMessages. Changed to a persistent instance field so each middleware gets a unique variable name. Closes #2326 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 22, 2026
This was referenced Mar 29, 2026
This was referenced Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Chain.AddMiddleware()resetting theOutgoingMessagesvariable counter to 100 on every call, causing duplicateoutgoingMessages101variable names when multiple middleware methods (e.g.,BeforeandLoad) returnOutgoingMessages_middlewareOutgoingCounter) so each middleware gets a unique variable nameCloses #2326
Test plan
Bug_2326_disambiguate_outgoing_messages_from_multiple_middlewaretest that verifies a handler with two middleware methods both returningOutgoingMessagescompiles successfully🤖 Generated with Claude Code