Fix shared subscription listener matching for MQTT#2236
Merged
jeremydmiller merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
MqttListener.TopicName was set to the full subscription string (e.g. $share/group/topic) but incoming messages arrive with the actual topic name. Changed to use ListeningTopic which strips the $share prefix, allowing MqttTopicFilterComparer to match correctly. Added Mosquitto Docker container and compliance tests including shared subscription tests with specific and wildcard topics. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 26, 2026
This was referenced Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MqttListener.TopicNamewas set to the full shared subscription string (e.g.$share/group/topic), but the MQTT broker delivers messages with the actual topic name (without$share/prefix).tryFindListenercouldn't match incoming messages becauseMqttTopicFilterComparerdoesn't understand the$share/prefix format.MqttListenerto usetopic.ListeningTopic(which strips the$share/group/prefix) instead oftopic.TopicName, so incoming messages match correctly against the listener's topic filter.Test plan
incoming/+) topic passes against real Mosquitto broker🤖 Generated with Claude Code