Remove duplicated code snippet from "Manually adding Envelope Mapping" section#2121
Merged
jeremydmiller merged 1 commit intoJasperFx:mainfrom Feb 6, 2026
Conversation
Member
|
@dmytro-pryvedeniuk Thank you! |
This was referenced Feb 11, 2026
This was referenced Mar 1, 2026
This was referenced Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Manually adding Envelope Mapping" section (see https://wolverinefx.net/guide/durability/efcore/outbox-and-inbox.html#manually-adding-envelope-mapping) contains 2 almost identical code snippets. The only difference is
map.ToTable("items");vsmap.ToTable("items", "mt_items");line.Technically they are different sources sharing the same region -
sample_mapping_envelope_storage_to_dbcontextbut from documentation side they look like strange duplication.To avoid confusion
SampleMappedDbContextfrom PersistentTests project is removed. It's not actually used (as well asCleanDbContextthere). AnotherSampleMappedDbContextclass from EfCoreTests project remains as a valid code snippet.