Skip to content

Remove log failure to Console from ExtensionLoader#1259

Open
ArturDorochowicz wants to merge 1 commit intoJasperFx:mainfrom
ArturDorochowicz:patch-1
Open

Remove log failure to Console from ExtensionLoader#1259
ArturDorochowicz wants to merge 1 commit intoJasperFx:mainfrom
ArturDorochowicz:patch-1

Conversation

@ArturDorochowicz
Copy link
Copy Markdown

Fixes #1258

@jeremydmiller
Copy link
Copy Markdown
Member

@ArturDorochowicz Hey man, I'm sorry, but this is the very epitome of the "solves my tactical problem, doesn't address a strategic concern" pull request. I didn't just put the console output on failures there for fun. What you did is essentially swallowing a potential problem. Like I told you before, you can simply opt out of the automatic extension finding altogether. Or come up with some kind of "suppress assembly warnings" flag I guess.

@jeremydmiller
Copy link
Copy Markdown
Member

If you wanna try this a different way that just latches the logging on assembly failures, I'm good to take that. But this just treats the symptoms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scanning for extensions may write dll paths to console

2 participants