Repository navigation
docs: fix mismatched and missing code samples - #4737
Merged
Merged
Conversation
- querying/advanced-sql: the 'support parameters' section embedded the schema-resolver snippet; point it at sample_advanced_sql_query_parameters - documents/aspnetcore: the 'compiled query' sample used a plain LINQ query identical to the non-compiled one; rewrite Get3 to use the IssueById compiled query via session.WriteOne(...) - events/skipping: page was truncated with no example; add a sample_mark_events_as_skipped region for the MarkEventsAsSkipped helper - documents/storing: removed a duplicate 'asynchronous version' bulk-insert snippet that was byte-identical to the one above it (all bulk insert APIs are async) - documents/deletes: replaced a mismatched global-soft-delete snippet under the DeletedSince/DeletedBefore exclusivity note with the actual statement - events/querying: add Tags, UserName, IsSkipped and AddTag(...) members to the inline IEvent interface listing
This was referenced Jun 15, 2026
Merged
This was referenced Jun 22, 2026
This was referenced Aug 3, 2026
This was referenced Aug 10, 2026
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Third follow-up from the docs audit: pages whose embedded sample pointed at the wrong
#region, was missing, or was duplicated. Where the right sample didn't exist, the source was given a proper region (andmdsnippetsregenerated the markdown).Fixes
querying/advanced-sql— the "AllAdvancedSqlmethods also support parameters" section embeddedsample_document_schema_resolver_resolve_schemas(schema-name resolution). Pointed it atsample_advanced_sql_query_parameters, which actually demonstrates parameter usage.documents/aspnetcore— the "compiled query" sample (Get3) was a plain LINQ query byte-identical to the non-compiledGet2. Rewrote it to use the existingIssueByIdcompiled query viasession.WriteOne(new IssueById { Id = issueId }, HttpContext)(theICompiledQueryoverload).IssueServicebuilds clean.events/skipping— the page ended mid-sentence ("…or this helper API:") with no example. Added asample_mark_events_as_skippedregion around the existingMarkEventsAsSkippedhelper and referenced it.documents/storing— removed a second "asynchronous version" bulk-insert snippet that was byte-identical to the one above it; all bulk-insert APIs are already async.documents/deletes— under "NeitherDeletedSincenorDeletedBeforeare inclusive…" the embedded snippet was an unrelated global-soft-delete config. Replaced with the actual statement of the exclusivity behavior.events/querying— added theTags,UserName,IsSkipped, andAddTag(...)members to the inlineIEventinterface listing to match the current interface.Source changes
Only
IssueController.Get3(compiled-query usage) and a new#regionmarker inEventSkipping.cs; the rest is regenerated markdown.🤖 Generated with Claude Code