Repository navigation
docs: fix snippet-source inaccuracies and regenerate - #4736
Merged
Merged
Conversation
Corrects defects that live inside generated snippet blocks (source #region markers), then regenerates the markdown: - diagnostics: sync Count()/Any() -> CountAsync()/AnyAsync() (sync query execution was removed in Marten 9) - linq/operators: drop Last()/LastOrDefault() from the element-operations sample (Marten throws on them; reverse the order and use First()) - events/appending: append-mode comment said Rich is the default 'from 4.0 on'; the default is QuickWithServerTimestamps as of Marten 9 - subscriptions: AfterCommit/BeforeCommit log messages were swapped - multi-stream/optimizing: cache comment said 100 but the value is 1000 - computed-indexes/unique: copy-paste 'brin' comment over a sort-order set - schema/authorization: table-creation comment implied DropThenCreate is the default; CreateIfNotExists is the default
This was referenced Jun 15, 2026
Merged
This was referenced Jun 22, 2026
This was referenced Aug 3, 2026
This was referenced Aug 10, 2026
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Second follow-up from the docs audit. These defects live inside generated snippet blocks, so the fix is in the source
#regionmarkers; the markdown is then regenerated withmdsnippets. Source changes are comment-only except where noted.Fixes
diagnostics/sample_using_request_count— syncCount()/Any()→CountAsync()/AnyAsync(). Synchronous query execution was removed in Marten 9 (these would throwNotSupportedException). Request count is unchanged (3).linq/operators/sample_select_a_single_value— removedLast()/LastOrDefault()from the element-operations sample. Marten throwsInvalidOperationExceptionon them; the guidance is to reverse the ordering and useFirst()/FirstOrDefault(). Comment updated accordingly.events/appending/sample_configuring_event_append_mode— comment claimedRichis the default "from 4.0 on"; the default isQuickWithServerTimestampsas of Marten 9.events/subscriptions/sample_errorhandlingsubscription—AfterCommitAsyncandBeforeCommitAsynclog messages were swapped.multi-stream+optimizing/sample_showing_fanout_rules— cache comment said "up to 100" but the value is1000.computed-indexes+unique/sample_customizing-calculated-index— copy-paste "Change the index method to brin" comment sat over aSortOrder.Descassignment.schema/authorization/sample_customizing_table_creation— comment impliedDropThenCreateis the default;CreateIfNotExistsis the default.Verification
mdsnippetsregenerated the affected markdown (incidental snippet source-link line-number refreshes ride along).Marten.Testingbuilds clean (the only non-comment source edits —CountAsync/AnyAsyncand the removedLast()lines — are there).🤖 Generated with Claude Code