Repository navigation
Fix ISoftDeleted in-memory update and NodaTime index IMMUTABLE errors - #4124
Merged
Merged
Conversation
When Delete<T>(T entity) is called on a document implementing ISoftDeleted, the in-memory Deleted and DeletedAt properties are now set immediately. Previously only the database was updated. Closes GH-2924 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Registers an IMemberSource in the NodaTime plugin that maps NodaTime types to the existing mt_immutable_* PostgreSQL functions, fixing index creation that previously failed with "functions in index expression must be marked IMMUTABLE". Closes GH-2415 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 17, 2026
This was referenced Mar 2, 2026
This was referenced Mar 16, 2026
This was referenced Mar 30, 2026
This was referenced May 11, 2026
This was referenced May 14, 2026
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ISoftDeletedshould update properties when you callIDocumentSession.Delete<T>(T document)#2924: WhenDelete<T>(T entity)is called on a document implementingISoftDeleted, the in-memoryDeletedandDeletedAtproperties are now set immediately. Previously only the database row was updated.mt_immutable_*PostgreSQL wrapper functions, fixing index creation on NodaTime types (LocalDate,Instant,LocalDateTime, etc.) that previously failed with "functions in index expression must be marked IMMUTABLE".Closes #2924
Closes #2415
Test plan
delete_sets_ISoftDeleted_properties_on_in_memory_documentverifies in-memory properties are updatedcan_index_noda_time_typesverifies indexes can be created on NodaTime fields🤖 Generated with Claude Code