Skip to content

Avoid extra cmd arguments causing issues with Wolverine-based systems#220

Merged
Hawxy merged 6 commits intoJasperFx:masterfrom
dmytro-pryvedeniuk:bug-217-extra
Mar 24, 2026
Merged

Avoid extra cmd arguments causing issues with Wolverine-based systems#220
Hawxy merged 6 commits intoJasperFx:masterfrom
dmytro-pryvedeniuk:bug-217-extra

Conversation

@dmytro-pryvedeniuk
Copy link
Copy Markdown
Contributor

@dmytro-pryvedeniuk dmytro-pryvedeniuk commented Mar 23, 2026

#217 does not change the behavior - extra "Logging" parameters are still included as cmd arguments.

This PR is another fix for #211 and #217 without extra cmd arguments.

@dmytro-pryvedeniuk
Copy link
Copy Markdown
Contributor Author

@Hawxy Note that

            { "Logging__EventLog__LogLevel__Default", nameof(LogLevel.None) },
            { "Logging__LogLevel__Microsoft.Identity.Web", nameof(LogLevel.None)}

does not work as expected.

Not only can_stub_schemes_for_different_hosts_with_identity_logger_disabled_by_default fails on CI (Linux), but does_not_fail_on_host_disposal_for_minimal_api starts to fail again on Windows.

Shouldly.ShouldAssertException: failedIterations

Shouldly.ShouldAssertException
failedIterations
    should be
0
    but was
9
   at Alba.Testing.Acceptance.host_stop_usage_repeated.does_not_fail_on_host_stop_for_minimal_api(Type type) in E:\dmp\Wolverine\alba\src\Alba.Testing\Acceptance\host_stop_usage_repeated.cs:line 52
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task, ConfigureAwaitOptions options)
   at Xunit.v3.TestRunner`2.<>c__DisplayClass5_0.<<InvokeTest>b__1>d.MoveNext() in /_/src/xunit.v3.core/Runners/TestRunner.cs:line 170
--- End of stack trace from previous location ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task, ConfigureAwaitOptions options)
   at Xunit.v3.ExceptionAggregator.RunAsync(Func`1 code) in /_/src/xunit.v3.core/Exceptions/ExceptionAggregator.cs:line 124



Iteration #0: started, Thread: 12
Stopping 3686381, Thread: 12
Stopped 3686381, Thread: 12
Iteration #0: stopped, Thread: 12

Iteration #1: started, Thread: 12
Stopping 61160508, Thread: 12
Failed System.ObjectDisposedException 61160508, Thread: 12
Iteration #1: stopped, Thread: 12

Iteration #2: started, Thread: 12
Stopping 20281500, Thread: 12
Failed System.ObjectDisposedException 20281500, Thread: 12
Iteration #2: stopped, Thread: 12

Iteration #3: started, Thread: 12
Stopping 1177678, Thread: 12
Failed System.ObjectDisposedException 1177678, Thread: 12
Iteration #3: stopped, Thread: 12

Iteration #4: started, Thread: 12
Stopping 62416960, Thread: 12
Failed System.ObjectDisposedException 62416960, Thread: 12
Iteration #4: stopped, Thread: 12

Iteration #5: started, Thread: 12
Stopping 19764571, Thread: 12
Failed System.ObjectDisposedException 19764571, Thread: 12
Iteration #5: stopped, Thread: 12

Iteration #6: started, Thread: 12
Stopping 40889321, Thread: 12
Failed System.ObjectDisposedException 40889321, Thread: 12
Iteration #6: stopped, Thread: 12

Iteration #7: started, Thread: 12
Stopping 19650377, Thread: 12
Failed System.ObjectDisposedException 19650377, Thread: 12
Iteration #7: stopped, Thread: 12

Iteration #8: started, Thread: 12
Stopping 34837044, Thread: 12
Failed System.ObjectDisposedException 34837044, Thread: 12
Iteration #8: stopped, Thread: 12

Iteration #9: started, Thread: 12
Stopping 34424014, Thread: 12
Failed System.ObjectDisposedException 34424014, Thread: 12
Iteration #9: stopped, Thread: 12

@dmytro-pryvedeniuk
Copy link
Copy Markdown
Contributor Author

@Hawxy @jeremydmiller The current changes should be enough. No extra command line parameters are required.

@dmytro-pryvedeniuk
Copy link
Copy Markdown
Contributor Author

The tests are stable

image

@dmytro-pryvedeniuk dmytro-pryvedeniuk marked this pull request as ready for review March 23, 2026 19:43
@dmytro-pryvedeniuk dmytro-pryvedeniuk changed the title Check used cmd arguments Avoid extra cmd arguments causing issues with Wolverine-based systems Mar 23, 2026
@Hawxy Hawxy merged commit 7cdc410 into JasperFx:master Mar 24, 2026
1 check passed
@dmytro-pryvedeniuk dmytro-pryvedeniuk deleted the bug-217-extra branch April 2, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants