Skip to content

Upgrade to Windows App SDK 1.3 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Conversation

JasonWei512
Copy link
Owner

The wrong Mica theme bug is fixed in Windows App SDK 1.3, so this workaround is no longer needed.

Known Issues

On my laptop, app may crash when launching.

This wonrg theme issue is fixed in Windows App SDK 1.3. The workaround is no longer necessary.
@JasonWei512
Copy link
Owner Author

About the crash

Windows App SDK 1.3's new SystemBackdrop API requires the window to have content.
If I set MainWindow.SystemBackdrop when MainWindow.Content is null, the app may crash on launch.
microsoft/WindowsAppSDK#3406 (comment)

The workaround

Set MainWindow.SystemBackdrop after setting MainWindow.Content.

@JasonWei512 JasonWei512 merged commit bb95320 into develop Apr 18, 2023
@JasonWei512 JasonWei512 deleted the optimize/windows-app-sdk-1.3 branch April 19, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant