feat: allow blacklisting of MPRIS players#1139
Open
Times-Z wants to merge 3 commits intoJas-SinghFSU:masterfrom
Open
feat: allow blacklisting of MPRIS players#1139Times-Z wants to merge 3 commits intoJas-SinghFSU:masterfrom
Times-Z wants to merge 3 commits intoJas-SinghFSU:masterfrom
Conversation
Jas-SinghFSU
requested changes
Jan 3, 2026
src/lib/shared/media/index.ts
Outdated
Comment on lines
5
to
21
| /** | ||
| * Gets the desktop entry name from an MPRIS player. | ||
| * | ||
| * The desktop entry typically contains the actual application name, | ||
| * which is more reliable than the bus name for Electron apps. | ||
| * | ||
| * @param player The MPRIS player. | ||
| * | ||
| * @returns The desktop entry name or empty string. | ||
| */ | ||
| const getDesktopEntry = (player: AstalMpris.Player): string => { | ||
| try { | ||
| return player.entry || ''; | ||
| } catch { | ||
| return ''; | ||
| } | ||
| }; |
Owner
There was a problem hiding this comment.
Seems to be unused, can we remove?
Author
There was a problem hiding this comment.
Yep, my bad test that I doens't remove
Owner
|
Looks good outside of the comment above and the linter failures. |
lika85456
added a commit
to lika85456/HyprPanel
that referenced
this pull request
Feb 3, 2026
Also add the ability to set one of them as the default value when available
Author
|
Any news ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to ignore unwanted MPRIS players and set a preferred default player, similar to the existing ignored applications feature for notifications
Features Added
1. Ignore MPRIS Players
ignoreconfiguration option to filter out unwanted MPRIS clients2. Preferred Player
preferredPlayerconfiguration option to set a default MPRIS player3. CLI Tool for Discovery
hyprpanel mprisPlayers(alias:mpl) command