Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for diff files #41

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

TGiles
Copy link
Contributor

@TGiles TGiles commented Sep 24, 2021

This change adds support for some common situations involving diff files. Closes #40

I didn't include it in this change but something I've seen in other themes is punctuation.definition.changed.diff but I couldn't figure out what it matched, so maybe that's something that can be added later once someone figures out what it corresponds to.

@Jaredk3nt
Copy link
Owner

Awesome! Could you add some screenshots here of it as well 👍

@TGiles
Copy link
Contributor Author

TGiles commented Oct 4, 2021

First, the regular theme
image

Second, the high contrast theme
image

Hope this helps!

@Jaredk3nt
Copy link
Owner

Sorry for the delay in responses I should have some free time tonight to look through everything for real!

TBH since the aqua is in the file, it almost feels like that should be used for additions rather than the blue since green is typically used and that is much more green... I might play around with how it looks in the git diff view as well. Curious on your thoughts

@TGiles
Copy link
Contributor Author

TGiles commented Oct 5, 2021

no worries, I understand being a maintainer :) there's no rush on my end, just trying to make the theme even better 🎉

TBH since the aqua is in the file, it always feels like that should be used for additions rather than the blue.

Let me make sure I understand correctly, the suggestion is swap out the coloring used for diff --git for the coloring used for inserting new lines? It'd probably be more cohesive since green is typically used for inserts, not entirely sure why I went with the blue for inserts over green lol.

@Jaredk3nt
Copy link
Owner

I also use maximum blue in the VSCode source control tab to highlight added code, but now that the lines are actually colored rather than highlighted with it it's more obvious that its blue when it should be green.

I'm going to try out the green in both cases tonight and see if I think that looks more natural in both this case and the existing one.

@Jaredk3nt Jaredk3nt merged commit 3b40aa8 into Jaredk3nt:master Oct 6, 2021
@Jaredk3nt
Copy link
Owner

Released in v1.3.3 🎉

Thanks for keeping LaserWave awesome!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support diff language view
2 participants