Skip to content

Apply rules #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JaredCE merged 16 commits into from
Jan 10, 2026
Merged

Apply rules #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
17bb1dd
create a test for Workflow failures
JaredCE Jan 9, 2026
e6d5a8e
set Workflow Failure actions
JaredCE Jan 9, 2026
255ece2
create a setStepFailureActions test
JaredCE Jan 9, 2026
16c230e
create a setStepFailures function
JaredCE Jan 9, 2026
260de0d
buidl rules test
JaredCE Jan 9, 2026
8c5a76b
add a function to build out the rules
JaredCE Jan 9, 2026
4539553
update spec
JaredCE Jan 9, 2026
c1e05b3
separation of rules
JaredCE Jan 9, 2026
4458c45
prettifies and adds a JSON Pointer test
JaredCE Jan 10, 2026
030b59c
prettifies
JaredCE Jan 10, 2026
c37b8a9
update and add to the rules spec
JaredCE Jan 10, 2026
ef66fc1
check rules against criteria
JaredCE Jan 10, 2026
9f2fe54
more mock files
JaredCE Jan 10, 2026
55bff75
prettifies
JaredCE Jan 10, 2026
93ffafb
update spec for rules tests
JaredCE Jan 10, 2026
db836ca
removes deprecated code, adds an abort handler, checks rules
JaredCE Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
221 changes: 133 additions & 88 deletions src/Arazzo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const path = require("node:path");
const Document = require("./Document");
const docFactory = require("./DocFactory");
const Expression = require("./Expression");
const Rules = require("./Rules");

class MatrixParams {
constructor(matrixString = "") {
Expand Down Expand Up @@ -115,17 +116,41 @@ class Arazzo extends Document {
await this.getWorkflows();

await this.startWorkflows();

console.log("all workflows run");
}

async startWorkflows(index = 0) {
const continueRunning = await this.runWorkflow(index);
this.abortWorkflowController = new AbortController();

this.workflowIndex = index;
console.log("running workflow index", index);
if (index <= this.workflows.length - 1) {
await this.runWorkflow(index).catch((err) => {
if (err.name === "AbortError") {
} else {
throw err;
}
});

if (continueRunning.noMoreWorkflows === false) {
await this.startWorkflows(index + 1);
} else {
console.log("no more workflows");
}
// this.workflowIndex = index;
// const continueRunning = await this.runWorkflow(index);

// if (continueRunning.noMoreWorkflows === false) {
// await this.startWorkflows(index + 1);
// }
}

async runWorkflow(index) {
if (this.abortWorkflowController.signal.aborted) {
throw new DOMException("Aborted", "AbortError");
}

const rules = new Rules(this.expression);
const workflow = await this.JSONPickerToIndex("workflows", index);

if (workflow) {
Expand All @@ -138,6 +163,11 @@ class Arazzo extends Document {
this.expression.addToContext("inputs", this.inputs);

this.workflow = workflow;
this.workflow.rules = rules;

if (this.workflow.onSuccess) {
this.workflow.rules.setWorkflowSuccess(this.workflow.onSuccess);
}

await this.runSteps();

Expand Down Expand Up @@ -171,18 +201,34 @@ class Arazzo extends Document {
}

async runSteps(index = 0) {
const contineuRunning = await this.runStep(index);
if (this.abortWorkflowController.signal.aborted) {
throw new DOMException("Aborted", "AbortError");
}

if (contineuRunning.noMoreSteps === false) {
this.stepIndex = index;
if (index <= this.workflow?.steps?.length - 1) {
await this.runStep(index);
await this.runSteps(index + 1);
}

// console.log("no steps to run");
// const contineuRunning = await this.runStep(index);

// if (contineuRunning.noMoreSteps === false) {
// await this.runSteps(index + 1);
// }
}

async runStep(index) {
const step = this.workflow.steps[index];

if (step) {
this.step = step;
console.log(`running step: ${step.stepId}`);
if (this.step.onSuccess) {
this.workflow.rules.setStepSuccesses(this.step.onSuccess);
}

this.logger.notice(`Running Step: ${this.step.stepId}`);

await this.loadOperationData();
Expand Down Expand Up @@ -279,15 +325,13 @@ class Arazzo extends Document {
async dealWithResponse(response) {
this.doNotProcessStep = false;
this.alreadyProcessingOnFailure = false;
if (
this.step.successCriteria ||
this.step.onSuccess ||
this.step.onFailure
) {

if (this.step.successCriteria) {
if (this.step.successCriteria) {
const passedSuccessCriteria = this.hasPassedSuccessCriteria();

if (passedSuccessCriteria) {
await this.dealWithPassedRule(response);
} else {
if (this.step.onFailure) {
await this.dealWithFailedResponse();
Expand All @@ -298,10 +342,10 @@ class Arazzo extends Document {
}
}
}
}

if (this.step?.outputs && this.doNotProcessStep === false) {
await this.dealWithStepOutputs(response);
} else {
if (this.step?.outputs) {
await this.dealWithStepOutputs(response);
}
}
}

Expand All @@ -320,6 +364,82 @@ class Arazzo extends Document {
return hasPassed.length === this.step.successCriteria.length;
}

async dealWithPassedRule(response) {
if (this.step?.outputs) {
await this.dealWithStepOutputs(response);
}

const whatNext = this.workflow.rules.runRules(true);
console.log(whatNext);
if (whatNext.endWorkflow) {
this.workflowIndex += 1;
// const index = this.workflowIndex + 1;

console.log("ending workflow");
this.abortWorkflowController.abort();
throw new DOMException("Aborted", "AbortError");
console.log("still here though");
// this.abortStep = new AbortController();
// this.abortSignal = this.abortStep.signal;

// this.startWorkflows(index);
// this.abortSignal.addEventListener("abort", () => {
// console.log("in the listener");
// });
// console.log(this.abortSignal.aborted);
// console.log("back here");
} else if (whatNext.goto) {
console.log("goto command");
if (whatNext.stepId) {
const stepIndex = this.workflow.steps.findIndex(
(step) => step.stepId === whatNext.stepId,
);

if (stepIndex === -1) {
throw new Error(`goto Step does not exist within current workflow`);
}

await this.runSteps(stepIndex);
} else {
const workflowId = this.expression.resolveExpression(
whatNext.workflowId,
);

const workflowIndex = this.workflows.findIndex(
(workflow) => workflow.workflowId === workflowId,
);

if (workflowIndex === -1) {
throw new Error(
`goto Workflow does not exist within current workflows`,
);
}

// console.log(
// "is a run time?",
// this.expression.isARunTimeExpression(whatNext.workflowId),
// );
// console.log(whatNext.workflowId);
// if (this.expression.isARunTimeExpression(whatNext.workflowId)) {
// const value = this.expression.resolveExpression(whatNext.workflowId);
// if (value) {
// }
// } else {
// console.log("goto workflow");
// const workflowIndex = this.workflows.findIndex(
// (workflow) => workflow.workflowId === whatNext.workflowId,
// );

// if (!workflowIndex) {
// throw new Error(
// `goto Workflow does not exist within current workflows`,
// );
// }
// }
}
}
}

async dealWithStepOutputs(response) {
const json = await response.json().catch((err) => {
console.error(err);
Expand All @@ -339,64 +459,6 @@ class Arazzo extends Document {
});
}

// async dealWithOutputs(response) {
// const json = await response.json();

// if (this.step?.outputs) {
// const outputs = {}
// for (const key in this.step.outputs) {
// // console.log(key)

// const isARuntimeValue = this.matchesExpectedRunTimeExpression(this.step.outputs[key], '$response.');

// if (isARuntimeValue) {
// const parseResult = parse(this.step.outputs[key]);
// const parts = [];

// parseResult.ast.translate(parts);
// for (const result of parts) {
// if (result.at(0) === 'source') {
// // if (result.at(1) === 'body') {
// // outputs[key] = json;
// // // console.log(JSON.stringify(json))
// // }
// if (result.at(1).startsWith('body')) {
// // console.log(result.at(1))
// let path;
// if (result.at(1) === 'body') {
// path = '$'
// } else {
// const splitArr = result.at(1).split('body#/')
// path = `$..${splitArr[1]}`;
// }
// // console.log(path)
// const value1 = jp.query(json, path);
// // console.log(value1);
// }

// if (result.at(1).startsWith('header')) {
// const headerName = parts[3][1]
// outputs[key] = response.headers.get(headerName);
// }
// }
// // console.log(result)
// // if (result.at(1).at(0) === 'body' && !result?.at(3)) {
// // outputs[key] = json;
// // }

// // if (result[1].startsWith('header')) {
// // outputs[key] = response.headers[result[3][1]];
// // }
// }
// }
// }

// Object.assign(this.outputs, {[this.step.stepId]: outputs})
// }

// console.log(this.outputs);
// }

async dealWithFailedResponse() {
this.doNotProcessStep = false;
this.alreadyProcessingOnFailure = true;
Expand Down Expand Up @@ -529,23 +591,6 @@ class Arazzo extends Document {
return result;
}

// parseRunTimeExpression(expression) {
// let value = expression;
// if (test(value)) {
// const parts = []
// const parseResult = parse(value);
// parseResult.ast.translate(parts);
// console.log(parts);
// for (const part of parts) {
// if (part[0] === 'name') {
// value = this.inputs[part[1]];
// }
// }
// }

// return value;
// }

async loadOperationData() {
this.sourceDescription = this.getOperationIdSourceDescription();

Expand Down
Loading