-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enclosing transaction is closed error fix #490
Enclosing transaction is closed error fix #490
Conversation
Please be sure to follow these instructions to add a Note that you can do this in-place using the same branch and the same PR, as before. |
…eract with graph Signed-off-by: Den Kovalevsky <xdev.developer@gmail.com>
be646d1
to
13d92bf
Compare
done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worthwhile to run the TinkerPop tests (mvn clean install -Dtest.skip.tp=false -DskipTests=true
) as an additional check on this.
done
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay to me. Nice job tracking this down. Thanks for running tests. Glad to see everything passed and timings don't seem to be affected by the update.
@mbrukman It doesn't look like @davidclement90 has write access to the repo (his approval above has a caveat). |
Good catch, @sjudeng! My apologies, @davidclement90, I did not add you to the I just sent you an invitation to join the group; once you do, you will have write access to the JanusGraph repos, and your PR approvals will get the same green checkmark as other committers and maintainers. |
The mail was in my spam... |
…ansactions Enclosing transaction is closed error fix
…ansactions Enclosing transaction is closed error fix
Fixed enclosing transaction is closed error when multiple threads interact with graph
Fixes #422