Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enclosing transaction is closed error fix #490

Merged

Conversation

xdev-developer
Copy link
Contributor

Fixed enclosing transaction is closed error when multiple threads interact with graph
Fixes #422

@janusgraph-bot janusgraph-bot added the cla: yes This PR is compliant with the CLA label Sep 1, 2017
@mbrukman
Copy link
Member

mbrukman commented Sep 1, 2017

Please be sure to follow these instructions to add a Signed-off-by tag to your commits to signify commitment to the Developer Certificate of Origin.

Note that you can do this in-place using the same branch and the same PR, as before.

…eract with graph

Signed-off-by: Den Kovalevsky <xdev.developer@gmail.com>
@xdev-developer xdev-developer force-pushed the multitheaded-transactions branch from be646d1 to 13d92bf Compare September 1, 2017 20:18
@xdev-developer
Copy link
Contributor Author

done!

@mbrukman mbrukman requested review from pluradj and sjudeng September 1, 2017 20:21
Copy link
Contributor

@sjudeng sjudeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worthwhile to run the TinkerPop tests (mvn clean install -Dtest.skip.tp=false -DskipTests=true) as an additional check on this.

@xdev-developer
Copy link
Contributor Author

xdev-developer commented Sep 3, 2017

done

Reactor Summary:

JanusGraph: Distributed Graph Database ............. SUCCESS [  0.501 s]
JanusGraph-Core: Core Library for JanusGraph ....... SUCCESS [ 32.610 s]
JanusGraph-Test: Test Suite for JanusGraph ......... SUCCESS [26:31 min]
JanusGraph CodePipelines CI: Distributed release testing. SUCCESS [  3.543 s]
JanusGraph-BerkeleyJE: Distributed Graph Database .. SUCCESS [  02:01 h]
JanusGraph-Cassandra: Distributed Graph Database ... SUCCESS [  02:22 h]
JanusGraph-CQL: Distributed Graph Database ......... SUCCESS [  02:19 h]
JanusGraph-ElasticSearch: Distributed Indexing Support SUCCESS [  0.956 s]
JanusGraph-HBase: Parent Module .................... SUCCESS [  0.048 s]
JanusGraph-HBase: Version-independent Core ......... SUCCESS [  1.869 s]
JanusGraph-HBase: 0.98 Compatibility Shim .......... SUCCESS [  07:08 h]
JanusGraph-HBase: 1.x Compatibility Shim ........... SUCCESS [  01:59 h]
JanusGraph-HBase: Universal binary ................. SUCCESS [  0.140 s]
JanusGraph-Hadoop: Parent Module ................... SUCCESS [  5.752 s]
JanusGraph-Hadoop: Version-independent Core ........ SUCCESS [  4.516 s]
JanusGraph-Hadoop: 2.x Compatibility Shim .......... SUCCESS [  2.305 s]
JanusGraph-Hadoop: Universal binary ................ SUCCESS [  0.176 s]
JanusGraph-Lucene: Indexing Support ................ SUCCESS [  0.509 s]
JanusGraph-All: Complete JanusGraph Distribution ... SUCCESS [  0.731 s]
JanusGraph-Solr: Distributed Indexing Support ...... SUCCESS [  1.720 s]
JanusGraph-Dist: Tar and Zip Archives .............. SUCCESS [ 19.995 s]
JanusGraph-Dist: Archive with Hadoop 2 ............. SUCCESS [  2.440 s]
JanusGraph-Doc: AsciiDoc Manual for JanusGraph ..... SUCCESS [  6.357 s]
------------------------------------------------------------------------
BUILD SUCCESS
------------------------------------------------------------------------
Total time: 16:20 h
Finished at: 2017-09-03T17:48:09+03:00
Final Memory: 152M/1618M

Copy link
Contributor

@sjudeng sjudeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me. Nice job tracking this down. Thanks for running tests. Glad to see everything passed and timings don't seem to be affected by the update.

@sjudeng
Copy link
Contributor

sjudeng commented Sep 5, 2017

@mbrukman It doesn't look like @davidclement90 has write access to the repo (his approval above has a caveat).

@mbrukman
Copy link
Member

mbrukman commented Sep 6, 2017

Good catch, @sjudeng! My apologies, @davidclement90, I did not add you to the committers group in the @JanusGraph org when you were announced as a new committer. A belated welcome and thank you for your contributions!

I just sent you an invitation to join the group; once you do, you will have write access to the JanusGraph repos, and your PR approvals will get the same green checkmark as other committers and maintainers.

@sjudeng sjudeng merged commit fc2b004 into JanusGraph:master Sep 6, 2017
@xdev-developer xdev-developer deleted the multitheaded-transactions branch September 6, 2017 12:49
@davidclement90
Copy link
Contributor

The mail was in my spam...
I just accept it.

bwatson-rti-org pushed a commit to bwatson-rti-org/janusgraph that referenced this pull request Mar 9, 2019
…ansactions

Enclosing transaction is closed error fix
micpod pushed a commit to micpod/janusgraph that referenced this pull request Nov 5, 2019
…ansactions

Enclosing transaction is closed error fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This PR is compliant with the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edges traversal streaming - enclosing transaction is closed error.
5 participants