Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snakeyaml NoSuchMethodError in remote console #3764

Merged
merged 3 commits into from
May 12, 2023

Conversation

li-boxuan
Copy link
Member

When connecting to a remote gremlin server from gremlin console, a NoSuchMethodError is thrown. This commit fixes this bug and adds an integration test to verify correctness.

Fixes #3763


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

@janusgraph-bot janusgraph-bot added the cla: external Externally-managed CLA label May 9, 2023
@li-boxuan li-boxuan force-pushed the bug/fix-remote-connect branch from 9056705 to 4e0940b Compare May 9, 2023 15:43
@li-boxuan li-boxuan requested a review from FlorianHockmann May 9, 2023 15:43
@li-boxuan
Copy link
Member Author

li-boxuan commented May 9, 2023

@FlorianHockmann The previous fix didn't work. As @cdegroc pointed out, it was caused by the version incompatibility in JanusGraph and TinkerPop. The ultimate solution would be to upgrade TinkerPop version. Since this issue can be reproduced on 0.6 too, I'd like to fix it by downgrading snakeyaml first and backport it to 0.6.

@li-boxuan li-boxuan added this to the Release v1.0.0 milestone May 9, 2023
When connecting to a remote gremlin server from gremlin
console, a NoSuchMethodError is thrown. This commit fixes
this bug and adds an integration test to verify correctness.

Fixes JanusGraph#3763

Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
@li-boxuan li-boxuan force-pushed the bug/fix-remote-connect branch from 4e0940b to 5246cad Compare May 10, 2023 05:07
Copy link
Member

@FlorianHockmann FlorianHockmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous fix didn't work. As @cdegroc pointed out, it was caused by the version incompatibility in JanusGraph and TinkerPop. The ultimate solution would be to upgrade TinkerPop version. Since this issue can be reproduced on 0.6 too, I'd like to fix it by downgrading snakeyaml first and backport it to 0.6.

Sure, makes sense.

li-boxuan added 2 commits May 9, 2023 23:32
Need to close the graph at the end of each test

Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
@li-boxuan li-boxuan force-pushed the bug/fix-remote-connect branch from 506ed09 to 702d5f0 Compare May 11, 2023 04:48
@li-boxuan li-boxuan merged commit 7c9c30c into JanusGraph:master May 12, 2023
github-actions bot pushed a commit that referenced this pull request May 12, 2023
Fix snakeyaml NoSuchMethodError in the remote console

When connecting to a remote gremlin server from the gremlin
console, a NoSuchMethodError is thrown. This commit fixes
this bug and adds an integration test to verify correctness.

Fixes #3763

Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
(cherry picked from commit 7c9c30c)
@github-actions
Copy link

💚 All backports created successfully

Status Branch Result
v0.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

FlorianHockmann pushed a commit that referenced this pull request May 12, 2023
Fix snakeyaml NoSuchMethodError in the remote console

When connecting to a remote gremlin server from the gremlin
console, a NoSuchMethodError is thrown. This commit fixes
this bug and adds an integration test to verify correctness.

Fixes #3763

Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
(cherry picked from commit 7c9c30c)
li-boxuan added a commit that referenced this pull request May 12, 2023
Fix snakeyaml NoSuchMethodError in the remote console

When connecting to a remote gremlin server from the gremlin
console, a NoSuchMethodError is thrown. This commit fixes
this bug and adds an integration test to verify correctness.

Fixes #3763

Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
(cherry picked from commit 7c9c30c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.6 cla: external Externally-managed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoSuchMethodError: org.yaml.snakeyaml.constructor.Constructor.<init> on gremlin console
3 participants