-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix snakeyaml NoSuchMethodError in remote console #3764
Fix snakeyaml NoSuchMethodError in remote console #3764
Conversation
9056705
to
4e0940b
Compare
@FlorianHockmann The previous fix didn't work. As @cdegroc pointed out, it was caused by the version incompatibility in JanusGraph and TinkerPop. The ultimate solution would be to upgrade TinkerPop version. Since this issue can be reproduced on 0.6 too, I'd like to fix it by downgrading |
When connecting to a remote gremlin server from gremlin console, a NoSuchMethodError is thrown. This commit fixes this bug and adds an integration test to verify correctness. Fixes JanusGraph#3763 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
4e0940b
to
5246cad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous fix didn't work. As @cdegroc pointed out, it was caused by the version incompatibility in JanusGraph and TinkerPop. The ultimate solution would be to upgrade TinkerPop version. Since this issue can be reproduced on 0.6 too, I'd like to fix it by downgrading snakeyaml first and backport it to 0.6.
Sure, makes sense.
Need to close the graph at the end of each test Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk>
506ed09
to
702d5f0
Compare
Fix snakeyaml NoSuchMethodError in the remote console When connecting to a remote gremlin server from the gremlin console, a NoSuchMethodError is thrown. This commit fixes this bug and adds an integration test to verify correctness. Fixes #3763 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk> (cherry picked from commit 7c9c30c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Fix snakeyaml NoSuchMethodError in the remote console When connecting to a remote gremlin server from the gremlin console, a NoSuchMethodError is thrown. This commit fixes this bug and adds an integration test to verify correctness. Fixes #3763 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk> (cherry picked from commit 7c9c30c)
Fix snakeyaml NoSuchMethodError in the remote console When connecting to a remote gremlin server from the gremlin console, a NoSuchMethodError is thrown. This commit fixes this bug and adds an integration test to verify correctness. Fixes #3763 Signed-off-by: Boxuan Li <liboxuan@connect.hku.hk> (cherry picked from commit 7c9c30c)
When connecting to a remote gremlin server from gremlin console, a NoSuchMethodError is thrown. This commit fixes this bug and adds an integration test to verify correctness.
Fixes #3763
Thank you for contributing to JanusGraph!
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
master
)?For code changes:
For documentation related changes: