Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add origin parameter in Fido2ExternalAuthenticator script for attestation and assertion API calls #9248 #9974

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Add origin parameter in Fido2ExternalAuthenticator script for attestation and assertion API calls #9248 #9974

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0101b5d
feat(jans-fido2): add origin parameter in Fido2ExternalAuthenticator …
imran-ishaq Oct 29, 2024
860260f
refactor(docs): add origin parameter in Fido2ExternalAuthenticator sc…
imran-ishaq Oct 29, 2024
c5c2a7a
fix(jans-fido2): handle origin if http or https is missing #9248
imran-ishaq Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(docs): add origin parameter in Fido2ExternalAuthenticator sc… 
…ript for attestation and assertion API calls #9248

Signed-off-by: imran-ishaq <imranishaq024@gmail.com>
  • Loading branch information
@imran-ishaq
imran-ishaq committed Oct 29, 2024
commit 860260fc8889caf0fa42c1e5dcb8a9f5f50be684
4 changes: 2 additions & 2 deletions ...-catalog/person_authentication/fido2-external-authenticator/Fido2ExternalAuthenticator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ def prepareForStep(self, configurationAttributes, requestParameters, step):

try:
assertionService = Fido2ClientFactory.instance().createAssertionService(metaDataConfiguration)
assertionRequest = json.dumps({'username': userName}, separators=(',', ':'))
assertionRequest = json.dumps({'username': userName, 'origin', domain}, separators=(',', ':'))
assertionResponse = assertionService.authenticate(assertionRequest).readEntity(java.lang.String)
print "assertionResponse %s " % assertionResponse

Expand All @@ -190,7 +190,7 @@ def prepareForStep(self, configurationAttributes, requestParameters, step):
try:
attestationService = Fido2ClientFactory.instance().createAttestationService(metaDataConfiguration)

basic_json = {'username': userName, 'displayName': userName}
basic_json = {'username': userName, 'displayName': userName, 'origin', domain}


print " basic_json %s" % basic_json
Expand Down