Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jans-keycloak-integration): downgrade kc version to 25.0.6 #9767 #9769

Merged
merged 21 commits into from
Oct 16, 2024

Conversation

uprightech
Copy link
Contributor

Prepare


Description

Target issue

closes #issue-number-here

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

* updated the keycloak configuration file to reflect the  configuration for the storage-spi

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
…y vulns

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
Copy link

dryrunsecurity bot commented Oct 16, 2024

DryRun Security Summary

The provided code change updates the keycloak-server.version property in the jans-keycloak-integration project's pom.xml file from 26.0.0 to 25.0.6, which should be reviewed for potential security implications, compatibility, and regression testing.

Expand for full summary

Summary:

The provided code change is a modification to the pom.xml file in the jans-keycloak-integration project, where the keycloak-server.version property has been updated from 26.0.0 to 25.0.6. From an application security perspective, this change is worth reviewing for a few reasons:

  1. Dependency Version Updates: Updating dependencies, especially for security-critical components like Keycloak, is an important security practice. The version change from 26.0.0 to 25.0.6 should be reviewed to understand the reasons behind the change and whether it addresses any known security vulnerabilities.

  2. Potential Impact on Security Features: Keycloak is a widely used identity and access management (IAM) solution, and changes to the version used can impact the security features and functionality of the integrated application. The changes should be carefully evaluated to ensure that there are no regressions in security-related features or functionality.

  3. Compatibility and Regression Testing: Updating a major dependency like Keycloak can have broader implications for the application's functionality and stability. It's important to ensure that the application continues to function as expected and that there are no regressions or unintended consequences introduced by the version change.

Files Changed:

  • jans-keycloak-integration/pom.xml: This file has been modified to update the keycloak-server.version property from 26.0.0 to 25.0.6. This change should be carefully reviewed to understand the reasons behind the version update and to ensure that the application's security posture is maintained or improved as a result of the change.

Code Analysis

We ran 9 analyzers against 1 file and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer Findings
Sensitive Files Analyzer 1 finding

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@mo-auto mo-auto added the kind-dependencies Pull requests that update a dependency file label Oct 16, 2024
@uprightech uprightech requested review from yuriyz and moabu October 16, 2024 16:38
Copy link

Quality Gate Passed Quality Gate passed for 'keycloak-integration-parent'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@yuriyz yuriyz enabled auto-merge (squash) October 16, 2024 18:59
@yuriyz yuriyz merged commit 731e12b into main Oct 16, 2024
11 checks passed
@yuriyz yuriyz deleted the issue_9767 branch October 16, 2024 19:00
Copy link

imShakil pushed a commit that referenced this pull request Oct 28, 2024
#9769)

* fix(jans-linux-setup): improper scim configuration for jans kc #8210
* updated the keycloak configuration file to reflect the  configuration for the storage-spi

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

* chore(jans-keycloak-integration): bump kc version to 24.0.0 #8315

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

* chore(jans-keycloak-integration): update dependencies causing security vulns

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

* chore(jans-keycloak-integration): downgrade kc version to 25.0.6

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

---------

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
#9769)

* fix(jans-linux-setup): improper scim configuration for jans kc #8210
* updated the keycloak configuration file to reflect the  configuration for the storage-spi

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

* chore(jans-keycloak-integration): bump kc version to 24.0.0 #8315

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

* chore(jans-keycloak-integration): update dependencies causing security vulns

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

* chore(jans-keycloak-integration): downgrade kc version to 25.0.6

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

---------

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
Former-commit-id: 731e12b
moabu pushed a commit that referenced this pull request Dec 26, 2024
#9769)

* fix(jans-linux-setup): improper scim configuration for jans kc #8210
* updated the keycloak configuration file to reflect the  configuration for the storage-spi

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

* chore(jans-keycloak-integration): bump kc version to 24.0.0 #8315

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

* chore(jans-keycloak-integration): update dependencies causing security vulns

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

* chore(jans-keycloak-integration): downgrade kc version to 25.0.6

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

---------

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
moabu pushed a commit that referenced this pull request Dec 27, 2024
#9769)

* fix(jans-linux-setup): improper scim configuration for jans kc #8210
* updated the keycloak configuration file to reflect the  configuration for the storage-spi

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

* chore(jans-keycloak-integration): bump kc version to 24.0.0 #8315

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

* chore(jans-keycloak-integration): update dependencies causing security vulns

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

* chore(jans-keycloak-integration): downgrade kc version to 25.0.6

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>

---------

Signed-off-by: Rolain Djeumen <uprightech@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind-dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants