Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-linux-setup): mysql backend with setup.properties #9738

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

devrimyatar
Copy link
Contributor

closes #8113

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: Mustafa Baser <mbaser@mail.com>
@devrimyatar devrimyatar added kind-bug Issue or PR is a bug in existing functionality comp-jans-linux-setup Component affected by issue or PR labels Oct 14, 2024
Copy link

dryrunsecurity bot commented Oct 14, 2024

DryRun Security Summary

The provided patch sets the default database ports for MySQL and PostgreSQL in the jans_setup/setup_app/utils/properties_utils.py file to ensure the application can properly connect to the database.

Expand for full summary

Summary:

The code change in the provided patch is related to setting the default database port for MySQL and PostgreSQL databases in the jans_setup/setup_app/utils/properties_utils.py file. The change ensures that the default database ports are set correctly for the respective database types, which is important for the application to connect to the database properly. From an application security perspective, this change does not introduce any obvious security concerns, as it is a common practice to set default values for configuration parameters to make the setup process more user-friendly. However, it is important to ensure that the default values are secure and that the application is configured to use secure connections to the database (e.g., using SSL/TLS encryption).

Files Changed:

  • jans-linux-setup/jans_setup/setup_app/utils/properties_utils.py: This file has been modified to set the default database port for MySQL and PostgreSQL databases. Specifically, the code checks if the rdbm_type property is set to 'pgsql' and if the rdbm_port property is not set. If these conditions are met, it sets the rdbm_port property to '5432', which is the default port for PostgreSQL. Similarly, if the rdbm_type property is set to 'mysql' and the rdbm_port property is not set, it sets the rdbm_port property to '3306', which is the default port for MySQL.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

Copy link

DryRun Security Summary

The provided patch sets the default database ports for MySQL and PostgreSQL in the jans_setup/setup_app/utils/properties_utils.py file to ensure the application can connect to the database properly, without introducing any obvious security concerns.

Expand for full summary

Summary:

The code change in the provided patch is related to setting the default database port for MySQL and PostgreSQL databases in the jans_setup/setup_app/utils/properties_utils.py file. The change ensures that the default database ports are set correctly for the respective database types, which is important for the application to connect to the database properly. From an application security perspective, this change does not introduce any obvious security concerns, as it is a common practice to set default values for configuration parameters to make the setup process more user-friendly. However, it is important to ensure that the default values are secure and that the application is configured to use secure connections to the database (e.g., using SSL/TLS encryption).

Files Changed:

  • jans-linux-setup/jans_setup/setup_app/utils/properties_utils.py: This file has been modified to set the default database port for MySQL and PostgreSQL databases. Specifically, the code checks if the rdbm_type property is set to 'pgsql' and if the rdbm_port property is not set. If these conditions are met, it sets the rdbm_port property to '5432', which is the default port for PostgreSQL. Similarly, if the rdbm_type property is set to 'mysql' and the rdbm_port property is not set, it sets the rdbm_port property to '3306', which is the default port for MySQL.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

Copy link

@yuriyz yuriyz merged commit 75df2bf into main Oct 14, 2024
12 checks passed
@yuriyz yuriyz deleted the jans-linux-setup-setup-properties-mysql-8113 branch October 14, 2024 12:51
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Former-commit-id: 75df2bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(jans-linux-setup): getting error when installing jans/mysql with setup.properties
3 participants