-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: skip plugin build #9594
chore: skip plugin build #9594
Conversation
Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
DryRun Security SummaryThe pull request primarily involves changes to the project's build configuration and Dockerfile, which may impact the application's two-factor authentication functionality and contain hardcoded configuration values and sensitive information that should be externalized and managed securely. Expand for full summarySummary: The code changes in this pull request primarily involve modifications to the project's build configuration and the Dockerfile used for the Janssen Casa application. While the changes do not directly introduce any obvious security vulnerabilities, there are several security-related aspects that should be considered. The removal of the "email_2fa_core" module from the project's Maven configuration may impact the application's two-factor authentication (2FA) functionality, which is an important security feature. Additionally, the Dockerfile contains several hardcoded configuration values and sensitive information, which should be externalized and managed securely to prevent potential security risks. The Dockerfile also utilizes various techniques for dependency management, caching, and layer optimization, which can help improve the security and maintainability of the Docker image. However, it's crucial to ensure that all dependencies are kept up-to-date and that any known vulnerabilities are addressed in a timely manner. Files Changed:
Code AnalysisWe ran
Riskiness🟢 Risk threshold not exceeded. |
Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Quality Gate passed for 'jans-pycloudlib'Issues Measures |
Quality Gate passed for 'jans-config-api-parent'Issues Measures |
* chore: skip plugin build #9591 Signed-off-by: jgomer2001 <bonustrack310@gmail.com> * fix: adjust supported casa plugins Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com> * chore: remove agama project from plugin entry Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com> --------- Signed-off-by: jgomer2001 <bonustrack310@gmail.com> Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com> Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
* chore: skip plugin build #9591 Signed-off-by: jgomer2001 <bonustrack310@gmail.com> * fix: adjust supported casa plugins Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com> * chore: remove agama project from plugin entry Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com> --------- Signed-off-by: jgomer2001 <bonustrack310@gmail.com> Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com> Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com> Former-commit-id: df79335
* chore: skip plugin build #9591 Signed-off-by: jgomer2001 <bonustrack310@gmail.com> * fix: adjust supported casa plugins Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com> * chore: remove agama project from plugin entry Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com> --------- Signed-off-by: jgomer2001 <bonustrack310@gmail.com> Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com> Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
* chore: skip plugin build #9591 Signed-off-by: jgomer2001 <bonustrack310@gmail.com> * fix: adjust supported casa plugins Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com> * chore: remove agama project from plugin entry Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com> --------- Signed-off-by: jgomer2001 <bonustrack310@gmail.com> Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com> Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Prepare
Description
Target issue
closes #9591
Implementation Details
Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:
to indicate documentation changes or if the below checklist is not selected.