Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip plugin build #9594

Merged
merged 6 commits into from
Sep 30, 2024
Merged

chore: skip plugin build #9594

merged 6 commits into from
Sep 30, 2024

Conversation

jgomer2001
Copy link
Contributor

Prepare


Description

Target issue

closes #9591

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
Copy link

dryrunsecurity bot commented Sep 25, 2024

DryRun Security Summary

The pull request primarily involves changes to the project's build configuration and Dockerfile, which may impact the application's two-factor authentication functionality and contain hardcoded configuration values and sensitive information that should be externalized and managed securely.

Expand for full summary

Summary:

The code changes in this pull request primarily involve modifications to the project's build configuration and the Dockerfile used for the Janssen Casa application. While the changes do not directly introduce any obvious security vulnerabilities, there are several security-related aspects that should be considered.

The removal of the "email_2fa_core" module from the project's Maven configuration may impact the application's two-factor authentication (2FA) functionality, which is an important security feature. Additionally, the Dockerfile contains several hardcoded configuration values and sensitive information, which should be externalized and managed securely to prevent potential security risks.

The Dockerfile also utilizes various techniques for dependency management, caching, and layer optimization, which can help improve the security and maintainability of the Docker image. However, it's crucial to ensure that all dependencies are kept up-to-date and that any known vulnerabilities are addressed in a timely manner.

Files Changed:

  1. jans-casa/pom.xml: The changes in this file involve commenting out the plugins/email_2fa_core module, which may impact the application's two-factor authentication functionality. The file also includes comprehensive dependency management and build configuration, which are essential for maintaining a secure and stable application.

  2. docker-jans-casa/Dockerfile: The changes in this Dockerfile are related to the deployment of the Janssen Casa application. Key security-related aspects include the removal of the "email_2fa_core" plugin, the use of hardcoded configuration values, the management of environment variables, dependency management, and the implementation of security best practices, such as using a non-root user and setting appropriate permissions.

Code Analysis

We ran 9 analyzers against 2 files and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer Findings
Sensitive Files Analyzer 2 findings

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@mo-auto mo-auto added comp-jans-casa Touching folder /jans-casa kind-dependencies Pull requests that update a dependency file labels Sep 25, 2024
Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
@moabu moabu requested review from moabu and iromli as code owners September 25, 2024 17:14
@iromli iromli self-requested a review September 25, 2024 21:36
docker-jans-casa/Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Copy link

docker-jans-casa/Dockerfile Outdated Show resolved Hide resolved
@moabu moabu merged commit df79335 into main Sep 30, 2024
10 of 11 checks passed
@moabu moabu deleted the jans-casa-issue_9591 branch September 30, 2024 12:23
Copy link

imShakil pushed a commit that referenced this pull request Oct 3, 2024
* chore: skip plugin build #9591

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>

* fix: adjust supported casa plugins

Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>

* chore: remove agama project from plugin entry

Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>

---------

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
* chore: skip plugin build #9591

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>

* fix: adjust supported casa plugins

Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>

* chore: remove agama project from plugin entry

Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>

---------

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Former-commit-id: df79335
moabu added a commit that referenced this pull request Dec 26, 2024
* chore: skip plugin build #9591

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>

* fix: adjust supported casa plugins

Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>

* chore: remove agama project from plugin entry

Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>

---------

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
moabu added a commit that referenced this pull request Dec 27, 2024
* chore: skip plugin build #9591

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>

* fix: adjust supported casa plugins

Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>

* chore: remove agama project from plugin entry

Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>

---------

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
Signed-off-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-casa Touching folder /jans-casa kind-dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(jans-casa): remove building 2fa core email plugin
5 participants