Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update labels in fido2 page #9585

Merged
merged 2 commits into from
Sep 24, 2024
Merged

chore: update labels in fido2 page #9585

merged 2 commits into from
Sep 24, 2024

Conversation

jgomer2001
Copy link
Contributor

Prepare


Description

Target issue

closes #9544

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
Copy link

dryrunsecurity bot commented Sep 24, 2024

DryRun Security Summary

The pull request focuses on improving the user experience and security features related to FIDO2 authentication and Passkey management in the Jans Casa application, including simplifying the UI, adding support for platform authenticators, and aligning the terminology to use "Passkeys" instead of a mix of "Security Keys" and "Platform Authenticators".

Expand for full summary

Summary:

The code changes in this pull request appear to be focused on improving the user experience and security features related to the FIDO2 (Fast Identity Online) authentication and Passkey management in the Jans Casa application.

The key changes include the simplification of the title and UI text for the FIDO2 device management page, the addition of support for platform authenticators (e.g., TouchID), and the alignment of the terminology used throughout the application to use "Passkeys" instead of a mix of "Security Keys" and "Platform Authenticators". These changes suggest a shift towards a more user-friendly and security-focused approach to authentication, leveraging the latest standards like FIDO2 and Passkeys.

From an application security perspective, the changes are positive as they enhance the user's control over their authentication methods, provide support for hardware-backed security features, and align the application with the latest security standards. The removal of platform-specific details and the focus on a more unified Passkey management experience are also security-focused improvements that can enhance the overall security posture of the application.

Files Changed:

  1. jans-casa/app/src/main/webapp/user/fido2-detail.zul:

    • The title of the page has been changed to simplify the wording.
    • The code displays a list of registered FIDO2 devices, including both platform authenticators and U2F security keys, and provides options to edit or delete the devices.
    • The code includes sections for adding new FIDO2 devices and platform authenticators, with specific messaging and UI elements tailored for each.
  2. jans-casa/app/src/main/resources/labels/user.properties:

    • The previous text describing the "Security Keys and built-in Platform Authenticators" feature has been removed, and the section has been simplified to just mention "Passkeys".
    • The references to "Manage security keys" and "Register a security key" have been changed to "Manage passkeys" and "Register a security key", respectively.
    • The previous section that mentioned "Apple's PassKey" has been removed, suggesting a more platform-agnostic approach to Passkey support.

Code Analysis

We ran 9 analyzers against 2 files and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@mo-auto mo-auto added comp-jans-casa Touching folder /jans-casa kind-dependencies Pull requests that update a dependency file labels Sep 24, 2024
@moabu moabu merged commit 57f3e30 into main Sep 24, 2024
10 of 11 checks passed
@moabu moabu deleted the jans-casa-issue_9544 branch September 24, 2024 16:38
imShakil pushed a commit that referenced this pull request Oct 3, 2024
chore: update labels #9544

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
chore: update labels #9544

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Former-commit-id: 57f3e30
moabu added a commit that referenced this pull request Dec 26, 2024
chore: update labels #9544

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
moabu added a commit that referenced this pull request Dec 27, 2024
chore: update labels #9544

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-casa Touching folder /jans-casa kind-dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(jans-casa): update texts in fido enrollment pages
4 participants