-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jans-fido): correct display name for fido interception script #9485 #9574
Conversation
Signed-off-by: shekhar16 <shekharlaad1609@gmail.com>
DryRun Security SummaryThe code change in this pull request is a minor update to the display name and configuration of the "fido2 extension" script, which is responsible for handling FIDO2 authentication in the Jans authentication system. Expand for full summarySummary: The code change in this pull request appears to be a minor update to the display name of the "fido2 extension" script, changing it to "fido2_extension". This script is part of the Jans authentication system and is responsible for handling FIDO2 (Fast Identity Online) authentication. The change also updates the "jansConfProperty" for the "fido2_server_uri" configuration property, which specifies the URI of the FIDO2 server. This value is set to "https://%(hostname)s", which means it will use the hostname of the server where the Jans system is running. Overall, this code change is a relatively minor update and does not raise any significant security concerns. The changes are focused on the display name and configuration of the FIDO2 authentication functionality, which is a security-related feature. As an application security engineer, I would review the changes to ensure they do not introduce any unintended consequences or security vulnerabilities, but the changes themselves do not appear to be introducing any new security risks. Files Changed:
Code AnalysisWe ran Riskiness🟢 Risk threshold not exceeded. |
Quality Gate passed for 'jans-linux-setup'Issues Measures |
… (#9574) Signed-off-by: shekhar16 <shekharlaad1609@gmail.com> Co-authored-by: Devrim <devrimyatar@gluu.org>
… (#9574) Signed-off-by: shekhar16 <shekharlaad1609@gmail.com> Co-authored-by: Devrim <devrimyatar@gluu.org>
… (#9574) Signed-off-by: shekhar16 <shekharlaad1609@gmail.com> Co-authored-by: Devrim <devrimyatar@gluu.org>
Closes #9485