Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-fido): correct display name for fido interception script #9485 #9574

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

shekhar16
Copy link
Contributor

@shekhar16 shekhar16 commented Sep 23, 2024

Closes #9485

Signed-off-by: shekhar16 <shekharlaad1609@gmail.com>
Copy link

dryrunsecurity bot commented Sep 23, 2024

DryRun Security Summary

The code change in this pull request is a minor update to the display name and configuration of the "fido2 extension" script, which is responsible for handling FIDO2 authentication in the Jans authentication system.

Expand for full summary

Summary:

The code change in this pull request appears to be a minor update to the display name of the "fido2 extension" script, changing it to "fido2_extension". This script is part of the Jans authentication system and is responsible for handling FIDO2 (Fast Identity Online) authentication. The change also updates the "jansConfProperty" for the "fido2_server_uri" configuration property, which specifies the URI of the FIDO2 server. This value is set to "https://%(hostname)s", which means it will use the hostname of the server where the Jans system is running.

Overall, this code change is a relatively minor update and does not raise any significant security concerns. The changes are focused on the display name and configuration of the FIDO2 authentication functionality, which is a security-related feature. As an application security engineer, I would review the changes to ensure they do not introduce any unintended consequences or security vulnerabilities, but the changes themselves do not appear to be introducing any new security risks.

Files Changed:

  • jans-linux-setup/jans_setup/templates/scripts.ldif: This file contains the configuration for the "fido2 extension" script, which is responsible for handling FIDO2 authentication. The changes in this pull request update the display name of the script from "fido2 extension" to "fido2_extension", and update the "jansConfProperty" for the "fido2_server_uri" configuration property to use the hostname of the server where the Jans system is running.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@mo-auto mo-auto added comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Sep 23, 2024
Copy link

@yuriyz yuriyz merged commit 1b3ff7a into main Sep 24, 2024
12 checks passed
@yuriyz yuriyz deleted the issues_9485 branch September 24, 2024 09:12
imShakil pushed a commit that referenced this pull request Oct 3, 2024
… (#9574)

Signed-off-by: shekhar16 <shekharlaad1609@gmail.com>
Co-authored-by: Devrim <devrimyatar@gluu.org>
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
… (#9574)

Signed-off-by: shekhar16 <shekharlaad1609@gmail.com>
Co-authored-by: Devrim <devrimyatar@gluu.org>
Former-commit-id: 1b3ff7a
moabu pushed a commit that referenced this pull request Dec 26, 2024
… (#9574)

Signed-off-by: shekhar16 <shekharlaad1609@gmail.com>
Co-authored-by: Devrim <devrimyatar@gluu.org>
moabu pushed a commit that referenced this pull request Dec 27, 2024
… (#9574)

Signed-off-by: shekhar16 <shekharlaad1609@gmail.com>
Co-authored-by: Devrim <devrimyatar@gluu.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FIx : Not able to enable Fido2-extention script.
4 participants