-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloud-native): change lock-master-configuration to lock-server-configuration #9177
Conversation
…nfiguration Signed-off-by: iromli <isman.firmansyah@gmail.com>
DryRun Security SummaryThe pull request updates the configuration and endpoints related to the Janssen Lock Server, transitioning from the older "Lock Master" architecture to the newer "Lock Server" architecture, and ensuring the proper exposure and security of the Lock Server-related endpoints. Expand for full summarySummary: The code changes in this pull request focus on updating the configuration and endpoints related to the Janssen Lock Server, which is a critical component of the Janssen access and identity management system. The key changes include:
From an application security perspective, these changes are generally positive as they align the application with the newer and more secure "Lock Server" architecture. However, it's important to ensure that any clients or integrations that were relying on the older "/.well-known/lock-master-configuration" endpoint are updated to use the new "/.well-known/lock-server-configuration" endpoint. Additionally, it's crucial to review the overall Ingress and Virtual Service configurations to ensure that all the exposed endpoints are properly secured and that there are no unintended exposures or misconfigurations. The Docker image configurations should also be reviewed to ensure that they follow best practices for securing the application's deployment. Files Changed:
Code AnalysisWe ran
Riskiness🟢 Risk threshold not exceeded. |
Signed-off-by: iromli <isman.firmansyah@gmail.com>
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
Signed-off-by: Amro Misbah <amromisba7@gmail.com>
…onfiguration (#9177) * feat(cloud-native): change lock-master-confguration to lock-server-configuration Signed-off-by: iromli <isman.firmansyah@gmail.com> * chore: update JANS_SOURCE_VERSION Signed-off-by: iromli <isman.firmansyah@gmail.com> * feat(cloud-native): update lock endpoint Signed-off-by: Amro Misbah <amromisba7@gmail.com> * feat(jans-lock): update lock endpoint Signed-off-by: Amro Misbah <amromisba7@gmail.com> --------- Signed-off-by: iromli <isman.firmansyah@gmail.com> Signed-off-by: Amro Misbah <amromisba7@gmail.com> Co-authored-by: Amro Misbah <amromisba7@gmail.com> Former-commit-id: 23dc2e2
Prepare
Description
Target issue
closes #9176
Implementation Details
Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:
to indicate documentation changes or if the below checklist is not selected.