-
Notifications
You must be signed in to change notification settings - Fork 91
docs(jans-lock): update schema locations #9122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
DryRun Security SummaryThe pull request focuses on defining and managing access control rules for the "Application" resource type, with the addition of a comprehensive set of actions that can be granted to users and roles, and the removal of previous action definitions, which raises security concerns and requires a thorough review to ensure the application's security is not compromised. Expand for full summarySummary: The code changes in this pull request focus on the definition and management of access control rules for an application's resources, particularly the "Application" resource type. The changes involve the addition and removal of schema files that define various actions that can be performed on the "Application" resource by different principals (Users and Roles) within a specific context. The addition of the "20-actions-filesystem-core.schema" file introduces a comprehensive set of actions, such as "Compare", "Execute", "Monitor", "Read", "Search", "Share", "Tag", and "Write", that can be granted to Users and Roles. This suggests a robust and flexible access control system is being implemented. However, the removal of these action definitions from the "00-cedarling_core_schema.schema" and "00-cedarling_core_schema.json" files raises some security concerns. The removal of these actions could potentially impact the existing access control policies and authorization logic within the application, which should be carefully reviewed to ensure that the application's security posture is maintained. Overall, these changes are focused on the core security and access control mechanisms of the application, and it is crucial to thoroughly review the implementation and implications to ensure that the application's security is not compromised. Files Changed:
Code AnalysisWe ran Riskiness🟢 Risk threshold not exceeded. |
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this!
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
|
|
|
|
|
|
|
|
* docs(jans-lock): update schema locations Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com> * docs(jans-lock): factor out actions Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com> * docs: update location Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com> * docs(jans-lock): rename core schema Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com> --------- Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com> Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com> Former-commit-id: eafe308
Prepare
Description
Target issue
closes #9121
Implementation Details
Test and Document the changes
N/A
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:
to indicate documentation changes or if the below checklist is not selected.