-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: default acr script validation #8715
Conversation
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.
Note 🟢 Risk threshold not exceeded. Change Summary (click to expand)The following is a summary of changes in this pull request made by me, your security buddy 🤖. Note that this summary is auto-generated and not meant to be a definitive list of security issues but rather a helpful summary from a security perspective. Summary: The code changes in this pull request focus on improving the configuration and management of the default authentication method and custom scripts in the Janssen Server. From an application security perspective, the changes introduce several security-relevant features, such as validation of the availability and active status of the authentication method, clear error handling, and documented authentication method selection flow. Additionally, the ability to manage custom scripts through a command-line interface (CLI) provides flexibility, but also introduces potential security risks that should be carefully considered. The key security considerations include: ensuring that only valid and active authentication methods are used as the default, reviewing the code of custom scripts to mitigate vulnerabilities, carefully managing the configuration properties of custom scripts to prevent misconfigurations or unintended access to sensitive data, and implementing strict access controls and secure deployment practices to prevent unauthorized modifications to the custom scripts. Overall, the changes appear to be focused on improving the security and reliability of the Janssen Server's authentication and custom script management functionality. Files Changed:
Powered by DryRun Security |
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
|
||
!!! Note | ||
|
||
If a custom script that is set as *Default authentication method* is disabled or deleted then the default authentication value will be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pujavs if it is removed, what will be the fallback default authentication? Can AS live without any default authn method defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuriyz, my understanding that AS can live without explicit setting of default auth method, request your confirmation and advice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if nothing works, and no scripts then AS will fallback to "simple_password_auth".
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com>
* docs: user password validation Signed-off-by: pujavs <pujas.works@gmail.com> * docs: user password validation Signed-off-by: pujavs <pujas.works@gmail.com> * docs: user password validation Signed-off-by: pujavs <pujas.works@gmail.com> * docs: user password validation doc Signed-off-by: pujavs <pujas.works@gmail.com> * docs: user password validation doc Signed-off-by: pujavs <pujas.works@gmail.com> * docs: user password validation doc Signed-off-by: pujavs <pujas.works@gmail.com> * docs: default acr script validation Signed-off-by: pujavs <pujas.works@gmail.com> * docs: default acr script validation Signed-off-by: pujavs <pujas.works@gmail.com> * docs: default acr script validation Signed-off-by: pujavs <pujas.works@gmail.com> * docs: default acr script validation Signed-off-by: pujavs <pujas.works@gmail.com> * docs: move the note about cust scripts and add link to docs * docs: add information about absence of default * docs: reword the note Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com> * docs: remove the image from update section Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com> --------- Signed-off-by: pujavs <pujas.works@gmail.com> Signed-off-by: ossdhaval <343411+ossdhaval@users.noreply.github.com> Co-authored-by: Dhaval D <343411+ossdhaval@users.noreply.github.com> Former-commit-id: a394f11
Prepare
Description
Target issue
closes #8707
Implementation Details
Test and Document the changes