Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: changed CPU to vCPU #5917

Merged

Conversation

KyleChaukccs
Copy link
Contributor

Prepare


Description

Target issue

closes #4792

Implementation Details

Corrected the benchmarking document by changing 'CPU' to 'vCPU' at all places.


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Signed-off-by: KyleChaukccs <kylechaukccs@gmail.com>
@ossdhaval
Copy link
Contributor

@KyleChaukccs Fantastic first contribution. 🎉 We have reviewed the PR and it is good for merge.

@ossdhaval ossdhaval merged commit a3c1a16 into JanssenProject:main Aug 29, 2023
devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
Signed-off-by: KyleChaukccs <kylechaukccs@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(docs): benchmarking document mistakenly refers to 'vCPU' as 'CPU'
2 participants