Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #776 #2503

Merged
merged 3 commits into from
Oct 3, 2022
Merged

fix: #776 #2503

merged 3 commits into from
Oct 3, 2022

Conversation

maduvena
Copy link
Contributor

@mo-auto mo-auto added comp-jans-auth-server Component affected by issue or PR comp-jans-fido2 Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Sep 29, 2022
yuriyz
yuriyz requested changes Sep 29, 2022
View reviewed changes
jans-auth-server/server/src/main/java/io/jans/as/server/service/MDSUpdateTimer.java Outdated
*/
@ApplicationScoped
@Named
public class MDS3UpdateTimer {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear why timer with event is put in jans-auth-server. Shouldn't it be in fido2-server? fido2-server is separate war and can carry it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was in error, corrected

jans-auth-server/server/src/main/java/io/jans/as/server/service/MDSUpdateTimer.java Outdated
@Inject
private TocService tocService;

public void initTimer() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting is messed. (Check other java files, e.g. spaces (vs tabs), curly brackets (starting bracket is always in same line))

@maduvena maduvena requested a review from yuriyz September 29, 2022 15:20
yuriyz
yuriyz requested changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@yuriyz yuriyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fido2-server app initializer has to be used instead of jans-auth-server

@sonarqubecloud
Copy link

[Fido2 API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

yuriyz
yuriyz approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@yuriyz yuriyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved since changes are moved out of AS. Now we should let @yurem check fido related changes.

@yurem yurem merged commit a564431 into main Oct 3, 2022
@yurem yurem deleted the issue_776 branch October 3, 2022 17:03
This was referenced Nov 1, 2022
Merged
Merged
@mo-auto3 mo-auto3 mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurem yurem yurem approved these changes

@yuriyz yuriyz yuriyz approved these changes

Assignees
No one assigned
Labels
comp-jans-auth-server Component affected by issue or PR comp-jans-fido2 Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maduvena @yuriyz @yurem @mo-auto