feat: deprecate password files in favor of secrets #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
==========================================
- Coverage 68.80% 68.63% -0.17%
==========================================
Files 29 29
Lines 1683 1674 -9
==========================================
- Hits 1158 1149 -9
Misses 525 525
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com>
Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com>
Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com>
moabu
added a commit
to GluuFederation/cloud-native-edition
that referenced
this pull request
Dec 23, 2021
moabu
added
comp-docker-jans-auth-server
docker-jans-certmanager
comp-docker-jans-certmanager
comp-docker-jans-client-api
comp-docker-jans-config-api
comp-docker-jans-configurator
comp-docker-jans-fido2
comp-docker-jans-persistence-loader
comp-docker-jans-scim
and removed
docker-jans-certmanager
labels
This was referenced Jan 13, 2022
moabu
added a commit
that referenced
this pull request
Jan 13, 2022
* refactor(jans-pycloudlib): rewrite password file handler * chore: change warning message about password file * refactor(jans-pycloudlib): simplify password file check * feat(configurator): ensure persistence password saved on first init * docs(configurator): add missing initialization attributes * ci: update pycloud dev build * ci: use base ref as base * ci: simplify janspycloud image build * ci: fix branch name reference * ci: update pycloud workflow * ci: fix syntax * ci: fix image build * ci: pull * ci: pull * ci: try force * chore(jans-pycloudlib): updated build Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * chore(jans-pycloudlib): updated build Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * test(jans-pycloudlib): testcases for passwords * ci: pass token for user to make authenticated call * ci: remove force pushing * ci: change workflow name * ci: passing a token for authentication * ci: add remote url * ci: fix syntax * ci: action push * ci: adjust workflows for creating dev images * ci: enable auto merge * chore(jans-pycloudlib): updated build (#156) Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci: don't trigger updates on bot pushes * ci: fix syntax * ci: fix syntax * chore(jans-pycloudlib): updated build (#158) Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> * ci: update build dates in prep for next release * chore(jans-pycloudlib): updated build (#163) Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com> Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com> Co-authored-by: mo-auto <54212639+mo-auto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changeset deprecate password files (
sql_password,couchbase_password,couchbase_superuser_password) in favor of value from secrets.For existing deployments, the password from any of password files mentioned previously is saved into secrets. Subsequent deployment may remove the password files safely.
For fresh deployments, there are additional scopes and attributes that can be used to specify password for SQL and Couchbase databases.