Mobile platforms much more responsive #155
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 24, 2013 02:11
Mobile platforms don't click, they use touch events, and through some complicated mess of jQuery, no doubt, they're translated to clicks. The problem is that that takes a very long time. I bound the tab click handler to 'touchend' as well, and if it ever receives a touchend event it unbinds the click event so that the function isn't run twice. I'm almost certain there's a better way to do this. Additionally, I commented out the portion that propagated the active tab class to the li's children, on line 466, 467, and the end of 592. It's true that the li>a selector doesn't perform as well, but I don't think that the small speedup is worth it compared to using yet another class, especially considering that the selector doesn't need to traverse a complex structure to find li>a, that's the only element li holds usually. If you do want that, uncomment 466, 467, end of 592.
Just a minify of the real one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously took over a second to switch tabs, now is more or less instant.
Also commented out active tab class propagation to children. If you want that back, uncomment lines 466, 467, and the end of 592.