-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patched to work with cordova@10.0.0 #13
Conversation
There are some cc: @iMrDJAi |
@romuloalves Not sure about that, the only what I found necessary to include there are the packagingOptions {
pickFirst 'lib/x86/libnode.so'
pickFirst 'lib/armeabi-v7a/libnode.so'
pickFirst 'lib/arm64-v8a/libnode.so'
pickFirst 'lib/x86_64/libnode.so'
} If you get an error while building your project post it and I'll see. |
@iMrDJAi I found out this line (taking from your PR):
I changed this one and lines 220 and 273 too. |
@romuloalves Before doing anything further, try doing a fresh build. Recreate your project again, make sure to update everything, check you Cordova version.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks a lot for the contribution and sorry for taking so long to get back to you.
Tested with cordova@10.0.0 and cordova-android@9.0.0, It works fine!
Fix suggested by @staltz (JaneaSystems/nodejs-mobile#239 (comment))
Edit: I also updated cordova-ios to version 6.2.0 to fix a compatibility issue with cordova@10.0.0, then I added some github actions tests to the project.