Skip to content

Commit

Permalink
Set log level of PHC dropping an endpoint to debug (zalando#3098)
Browse files Browse the repository at this point in the history
This is needed not to log too many lines. Moreover, the information
about requests amount could be seen in the metrics, the information
about IPs being mitigated could be get from updateStats logs

Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
Co-authored-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
  • Loading branch information
2 people authored and Janardhan Sharma committed Jul 19, 2024
1 parent c124f71 commit d73033c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion proxy/healthy_endpoints.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ func (h *healthyEndpoints) filterHealthyEndpoints(ctx *context, endpoints []rout
for _, e := range endpoints {
dropProbability := e.Metrics.HealthCheckDropProbability()
if p < dropProbability {
ctx.Logger().Infof("Dropping endpoint %q due to passive health check: p=%0.2f, dropProbability=%0.2f",
ctx.Logger().Debugf("Dropping endpoint %q due to passive health check: p=%0.2f, dropProbability=%0.2f",
e.Host, p, dropProbability)
metrics.IncCounter("passive-health-check.endpoints.dropped")
unhealthyEndpointsCount++
Expand Down

0 comments on commit d73033c

Please sign in to comment.