This repository has been archived by the owner on Mar 9, 2020. It is now read-only.
Fix issue with hyperlinks xml tag being written to WorksheetXml when no hyperlinks exist in the worksheet #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…no hyperlinks exist in the worksheet
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Copied from Codeplex --
While working with EPPlus I noticed an issue with excels which have had their hyperlinks removed from a worksheet. Currently when you remove all hyperlinks from a sheet an empty hyperlinks tag is still written to the Worksheet Xml. Having this empty tag was causing a notification of the file being corrupt (Was recoverable) when opened in excel.
I added an extra check within the ExcelWorksheet.UpdateHyperLinks method to only place the hyperlinks tag once a non-null Uri is encountered.
Let me know if you need any other details or if you think this change will have a larger impact that anticipated.