Updates to markdown/html handling + deps and project#18
Open
jerdog wants to merge 1 commit intoJan0660:mainfrom
Open
Updates to markdown/html handling + deps and project#18jerdog wants to merge 1 commit intoJan0660:mainfrom
jerdog wants to merge 1 commit intoJan0660:mainfrom
Conversation
- Update Log73 package to version 0.8.0-preview2 - Enable nullable reference types - Set language version to C# 11.0 - Add implicit usings support - Update handling of HTML and markdown Project configuration: - Set PackAsTool and ToolCommandName for CLI distribution - Add package license (MIT) and repository URL - Set package output path to ./nupkg - Add package description
Contributor
|
Hi! I'm not the maintainer of this project, but I tried out this PR to see if it would fix #19. Unfortunately, I think it's unlikely this PR will be merged in its current state: it makes too many changes in one commit, resulting in a very large diff that's difficult to review. As a casual observer, I found it hard to discern the specific changes introduced by the PR. I would suggest breaking it up into multiple, smaller commits, each focusing on a single, isolated change. This would allow the maintainer to assess each change individually. As it stands, it feels like a significant rewrite. Sorry to be the bearer of bad news! |
|
Woww. Great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had some issues trying to convert docFX to Docusaurus (v3.7) and made some updates to some dependencies, project version, and HTML/markdown handling.
Project configuration:
Tested build on MacOS Sequoia 15.4.1, Apple Silicon
dotnet publish -c Release -r osx-x64 --self-contained true -p:PublishSingleFile=trueOutput:
./DocFxMarkdownGenoutput: