-
Notifications
You must be signed in to change notification settings - Fork 14
Open
Description
I see that in your CI workflow, you install a few more things than what is declared in your setup.py. Are they really needed? If so, they should be declared as install_requires or as optional dependencies in setup.py. Also see #47
PyAutoGalaxy/.github/workflows/main.yml
Lines 12 to 26 in 449d5a1
| - name: Checkout PyAutoConf | |
| uses: actions/checkout@v2 | |
| with: | |
| repository: rhayes777/PyAutoConf | |
| path: PyAutoConf | |
| - name: Checkout PyAutoFit | |
| uses: actions/checkout@v2 | |
| with: | |
| repository: rhayes777/PyAutoFit | |
| path: PyAutoFit | |
| - name: Checkout PyAutoArray | |
| uses: actions/checkout@v2 | |
| with: | |
| repository: Jammy2211/PyAutoArray | |
| path: PyAutoArray |
PyAutoGalaxy/.github/workflows/main.yml
Lines 71 to 75 in 449d5a1
| pip3 install -r PyAutoConf/requirements.txt | |
| pip3 install -r PyAutoFit/requirements.txt | |
| pip3 install -r PyAutoArray/requirements.txt | |
| pip3 install -r PyAutoArray/optional_requirements.txt | |
| pip3 install -r PyAutoGalaxy/requirements.txt |
Metadata
Metadata
Assignees
Labels
No labels