Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JPEGmini gets stuck at "Go to Folder:" (Sierra) #129

Closed
maxwellhibbert opened this issue Oct 31, 2016 · 4 comments
Closed

JPEGmini gets stuck at "Go to Folder:" (Sierra) #129

maxwellhibbert opened this issue Oct 31, 2016 · 4 comments
Labels
Priority: High Status: Help Needed Type: Fix

Comments

@maxwellhibbert
Copy link

imageOptim 1.14.8
JPEGmini Pro 1.9.8
macOS 10.12

JPEGmini is getting stuck on the file open dialogue with a input titled "Go to folder:" which has my user path inside. Then the script keeps going and tries ImageOptim.

I also get the same problem with grunt-imageoptim. I've not used ImageOptim-CLI or grunt-imageoptim in quite a while and not since updating to Sierra, so not sure if the new OS creates problems or not..

I've also tried with the normal version of JPEGmini with the same result.
@JamieMason
Copy link
Owner

Thanks @maxwellhibbert,
I'm not on Sierra just yet but will pick this up in the next few weeks.

@JamieMason
Copy link
Owner

I'm still not on Sierra but here is some information about the problem incase someone is able to help out before I can.

  1. The affected code I think will be these lines.
  2. I don't know for sure but my guess is that in Sierra the path text field 1 of sheet 1 of sheet 1 of window 1 could be different to the older versions of OS X.
  3. There's an App called UI Browser which lets you click on bits of the OSX UI and inspect them, a little bit like the Elements panel of Chrome DevTools. Using this on Sierra will help confirm what the correct path to use should be.

@JamieMason JamieMason changed the title JPEGmini gets stuck at Go to the Folder: JPEGmini gets stuck at "Go to Folder:" (Sierra) Jan 17, 2017
@JamieMason JamieMason mentioned this issue Jan 17, 2017
Closed
This was referenced Jan 30, 2017
Closed
Closed
JamieMason pushed a commit that referenced this issue Jan 30, 2017
@stefancrain @JamieMason
fix(jpegmini): the text field in sierra has changed to a combo box.
8551693 
closes #129

Debugging with UI Browser has shown me the input for JPEGmini has changed in
OSX 10.12.

The UI Browser report outputs:

```
application "JPEGmini"
    standard window "JPEGmini" (window 1)
        sheet (sheet 1)
            sheet (sheet 1)
                combo box (combo box 1)
```

Added OS X version check to maintain backward compatibility.

My first pass at logical changes were limited because EVAL doesn't seem to be
supported in Apple Script, could be improved with a better comparison for future
versions.

Updated to match code formatting and contribution guide.
@maxwellhibbert
Copy link
Author

You're a champion!
Will this update make it to the grunt version eventually?

@JamieMason
Copy link
Owner

Thanks goes to @stefancrain for sorting this. I've just released 1.4.3 of grunt-imageoptim.

@MoOx MoOx mentioned this issue Sep 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: High Status: Help Needed Type: Fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JamieMason @maxwellhibbert