fix(device): guard nil scope/deploymentState/target in platform sections#185
Merged
Conversation
BlueprintDetail.Scope, BlueprintDetail.DeploymentState, and BenchmarkResponseV2.Target are all omitempty pointer fields that can be nil when absent from API responses. Dereferencing them without a nil check caused a panic in fetchDevicePlatformSections goroutines when any blueprint or benchmark lacked these fields. Add nil guards before each dereference and cover all three cases with integration tests against a test httptest server. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ktn-jamf
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #184
Summary
BlueprintDetail.Scope,BlueprintDetail.DeploymentState, andBenchmarkResponseV2.Targetareomitemptypointer fields that can benilwhen absent from API responsesfetchDevicePlatformSectionsgoroutines (reported aspro device <serial>crashing in v1.10.0)Test plan
TestFetchDevicePlatformSections_NilBlueprintScope— blueprint with absent scope field does not panic, is excluded from outputTestFetchDevicePlatformSections_NilDeploymentState— blueprint with matching scope but absent deploymentState does not panic, appears with empty stateTestFetchDevicePlatformSections_NilBenchmarkTarget— benchmark with absent target field does not panic, is excluded from outputmake testpasses🤖 Generated with Claude Code