Update existing Notion pages with Canvas assignment changes (#385) #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change to regular typescript files
JamesNZL
changed the title
BREAKING CHANGE: This requires a new previously unheld capability on the integration. Existing users must reauthorise with Notion.
JamesNZL
force-pushed
the
#385-update-existing
branch
from
cb2aaad
to
8a40166
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #385
Caution
This functionality requires a new
Update Contentcapability for the integration.This introduces a breaking change—existing users of the extension must reauthorise with Notion.
This PR implements the ability for the extension to update previously-imported Notion pages with updated Canvas information, provided:
Note
The due/unlock date must have changed by at least a minute and a half.
The assignment data has been re-copied into the extension using the
Copy from Canvasbutton.The extension is configured correctly. The
Import Assignment Changestoggle for the changed property must be configured toImport.Export to Notionbutton is clicked.If all the above are met, the existing page should be updated with the new properties!