Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To keep compatibility, I added new methods for MagickImageCollection instead of replacing.
This PR includes other small fixes.
ToLower()returns weird value in some culture. Ex. In "tr-TR","I".ToLower()returnsı.Use the String.ToUpperInvariant method instead of the String.ToLowerInvariant method when you normalize strings for comparisonhere. So maybe I should've usedToUpperInvariant()instead.icon.png?size=32.try{}catch{}. I encountered too many Exceptions.They are not tested enough and some methods have been added in my sense. Please test and modify it to match the project policy.