Use the current invoked version of PHP

[exussum12]

Currently when multiple versions are installed, calling parallel lint
with any of them invokes the default php on the path.

[VasekPurchart]

I don't think the condition is enough, because $_SERVER['_'] contains the executable which was used to run the PHP script which is fine, if you invoke the lint as php parallel-lint, but it's not okay, when you run the tool directly: ./parallel-lint, then it would contain the parallel-lint executable, which is obviously not something you want to use to run the linting process.

Also these values of $_SERVER are not documented, so I am not sure, if it is ok, to rely on them, at least it should be tested, that it is populated.

[exussum12]

What about using realpath ('/proc/self/exe')

That should work in both cases ?

[fprochazka]

There is a PHP_BINARY, since PHP 5.4, that should be imho prefered, if available.

[exussum12]

Added that check @fprochazka Thanks!

[exussum12]

Error on the build is HHVM being unsupported

[exussum12]

Travis seem to have dropped 5,3 support too. Removing that from the build

[JakubOnderka]

Nice catch! I fixed build in master branch, can you please remove commits that change build and rebase it to current master?

[exussum12]

Updated

[JakubOnderka]

Just small code style: Can you please put space after // and start commend with big letter?

[exussum12]

Done

[kamazee]

defined takes string with a constant name as an argument, so here it checks if a constant with name /usr/bin/php or alike (PHP_BINARY's value) is defined which would most likely be false, so $settings->phpExecutable will likely never be set. Shouldn't it be defined('PHP_BINARY')?

[JakubOnderka]

True! @exussum12 Can you fix it?

[exussum12]

Good spot. Sorted

[kamazee]

Testing concerns should also be addressed, I guess.
Other than that — thanks for the useful addition! That's something that could be useful for me as well 👍