-
-
Notifications
You must be signed in to change notification settings - Fork 23
Fix bad anchors in v2 #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EmilyBourne
wants to merge
7
commits into
JakubAndrysek:core-update
Choose a base branch
from
EmilyBourne:ebourne-131-bad-anchors-v2
base: core-update
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix bad anchors in v2 #136
EmilyBourne
wants to merge
7
commits into
JakubAndrysek:core-update
from
EmilyBourne:ebourne-131-bad-anchors-v2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR corrects anchor generation for overloaded operators by extending constant lists, sanitizing section names, and enhancing numbering logic to handle hyphens, template markers, truncation ellipses, and private overloads. Sequence Diagram for Node Anchor Property LogicsequenceDiagram
title Sequence Diagram for Node Anchor Property Logic
participant N as Node
N->>N: .anchor (read property)
activate N
alt self._name in OVERLOAD_OPERATORS (updated list)
N->>N: .operator_num (read property with new logic)
activate N
N-->>N: num (calculated operator index)
deactivate N
N-->>N: anchor_string (formatted for operator)
else self.is_overloaded
N->>N: .name_url_safe (read property with new sanitization)
activate N
N-->>N: safe_name
deactivate N
N-->>N: anchor_string (formatted for overload)
else
N->>N: .name_url_safe (read property with new sanitization)
activate N
N-->>N: safe_name
deactivate N
N-->>N: anchor_string (formatted for basic name)
end
deactivate N
Updated Class Diagram for Node and ConstantsModuleclassDiagram
title Updated Class Diagram for Node and Constants
class Node {
+operator_num: int
+name_url_safe: str
+anchor: str
}
class ConstantsModule {
<<module>>
+OVERLOAD_OPERATORS: List~String~
}
Node ..> ConstantsModule : uses OVERLOAD_OPERATORS
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bad anchors created for:
operator()
(missing fromOVERLOAD_OPERATORS
)-
as this character is preserved in the anchorMyClass<Specialisation, Specialization>
)...
private
zone (where the documentation is not extracted by doxygen)This fixes #131
Summary by Sourcery
Correct anchor generation for operators and other section names in Markdown output
Bug Fixes:
Enhancements: