Skip to content

Made log tag protected as requested in issue #477 #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CI-Till-Krempel wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Made log tag protected as requested in issue #477 #488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion timber/src/main/java/timber/log/Timber.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class Timber private constructor() {
internal val explicitTag = ThreadLocal<String>()
Copy link

@ildar2 ildar2 Oct 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There probably should be a change here as well, as you want users to be able to manually set tags


@get:JvmSynthetic // Hide from public API.
internal open val tag: String?
protected open val tag: String?
get() {
val tag = explicitTag.get()
if (tag != null) {
Expand Down