The point of BinaryOperationInTimber lint rule

[bomiyr]

Can you describe the benefits of using String.format instead of creating string with '+' sign?
As I understand, appending strings with '+' should be much faster because it will be compiled to StringBuilder operations, when String.format should at first parse string (for '%s', '%d' etc.) and only after that insert all parameters into proper places.
Also '+' is simpler, when String.format can be cause of problem during making changes (you must sure that all specifiers have right types (%d, %s) and all parameters are in proper places)
Also it's often simpler to read code with '+', (just my opinion)

[JakeWharton]

Doing string concatenation requires the string to be created even when you are not logging. For String.format Timber will skip the formatting call when no one is listening for it.

[bomiyr]

Oh, interesting. I didn't think about it.
I use Timber on the project where having logs is extremely important, we don't disable them at all. And there are a lot (really, A LOT) of them. I updated Timber library yesterday and now I have many lint warnings. I'm worrying that if I change all string concatenation to String.format I will get slower performance.
For my opinion it is not worth to be a warning, but it is up to you.
Thanks

[JakeWharton]

Using Android's Log should give the same lint warning I think. I believe we
just lifted the same rule.

On Wed, Apr 13, 2016 at 12:04 PM bomiyr notifications@github.com wrote:

Oh, interesting. I didn't think about it.
I use Timber on the project where having logs is extremely important, we
don't disable them at all. And there are a lot (really, A LOT) of them. I
updated Timber library yesterday and now I have many lint warnings. I'm
worrying that if I change all string concatenation to String.format I will
get slower performance.
For my opinion it is not worth to be a warning, but it is up to you.
Thanks

—
You are receiving this because you commented.

Reply to this email directly or view it on GitHub
#132 (comment)

[bomiyr]

Android's log does not give such warning.
Lint gives warning about using string concatenation in TextView.setText(), but because of different reason (localization)

[MichaelEvans]

If you don't want to use it, you can always suppress it by adding

lintOptions {
        disable 'BinaryOperationInTimber'
}

to your build.gradle (or in a lint.xml file)

[JakeWharton]

We should add that to the README under the lint rule list.

On Thu, Apr 14, 2016 at 10:39 AM Michael Evans notifications@github.com
wrote:

If you don't want to use it, you can always suppress it by adding

lintOptions {
disable 'BinaryOperationInTimber'
}

to your build.gradle (or in a lint.xml file)

—
You are receiving this because you commented.

Reply to this email directly or view it on GitHub
#132 (comment)

[bomiyr]

Thanks, I'll use this lint option.

[jakubvimn]

I think that this warning is a false-positive when you use concatenation just to break the long line of a string constant:

Timber.e("long " +
                    " line")

In this case the concatenation should be done by the compiler and there's no sign for it in bytecode.
https://stackoverflow.com/questions/29881465/how-is-concatenation-of-final-strings-done-in-java