Create internal Modifier.testTag
#619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't looked at the PR yet, but we'll eventually need some kind of Espresso like testing API so we'll need this for node selection. I have no plans to expose any kind of node directly, though. I don't believe we need a public semantic tree either. |
JakeWharton
approved these changes
Jan 5, 2025
mosaic-runtime/src/commonTest/kotlin/com/jakewharton/mosaic/stuff.kt
Outdated
Show resolved
Hide resolved
JakeWharton
reviewed
Jan 5, 2025
mosaic-runtime/src/commonTest/kotlin/com/jakewharton/mosaic/stuff.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made it internal at the moment, since
NodeSnapshotsis still inside:mosaic-runtime, and thereforeModifier.testTagsimply cannot be used outside of this module without some kind of extension of theMosaicinterface, which I'm not sure about right now.This can be done through the extension function, which will check the
Mosaictype forMosaicCompositionand then search for the desired node...The Compose UI uses
SemanticsModifierand a number of other things that are used not only forTestTag, but also many other things. The most interesting thing for us there besidesTestTagisText, so in order not to drag a bunch of code, which is not at all necessary right now, plus integration is not easy, I decided to do it in a simple way.CHANGELOG.md's "Unreleased" section has been updated, if applicable.