Skip to content

Create mosaic-testing module #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

EpicDima
Copy link
Contributor

@EpicDima EpicDima commented Nov 17, 2024

Fixes #4


  • CHANGELOG.md's "Unreleased" section has been updated, if applicable.

@JakeWharton
Copy link
Owner

I really want to land this, but I want to play around with the API locally first. I just haven't had a lot of free time lately. I will try to get to it some day this week, hopefully tomorrow.

I think we can avoid exposing internal API for this by making the base testing API a little more generic. This would allow the normal testing API to still provide consuming of the rendered output, but the commonTest of the runtime could still consume the internal nodes.

@JakeWharton JakeWharton force-pushed the epicdima/create_mosaic_testing branch from ed65d33 to ed79af0 Compare December 20, 2024 05:05
@JakeWharton
Copy link
Owner

Just a rebase so I can start looking locally. I'm off for two weeks after tomorrow, so hoping to get some movement here.

At the very least, the test API needs changed to track the changes in Redwood and #507 where we get rid of the channel and capture changes after a call to sendFrame.

@JakeWharton JakeWharton force-pushed the epicdima/create_mosaic_testing branch from ed79af0 to 5e36d90 Compare January 3, 2025 20:10
@JakeWharton
Copy link
Owner

Note: still very broken, but closer. I want to pull out a few more changes ahead of this. We're close!

@JakeWharton JakeWharton force-pushed the epicdima/create_mosaic_testing branch from 5e36d90 to fd801ba Compare January 3, 2025 21:38
@JakeWharton JakeWharton enabled auto-merge (squash) January 3, 2025 21:38
@JakeWharton JakeWharton merged commit 321290f into JakeWharton:trunk Jan 3, 2025
12 checks passed
@EpicDima EpicDima deleted the epicdima/create_mosaic_testing branch January 3, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing support
2 participants