Skip to content

Fix laggy dragging #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Fix laggy dragging #26

merged 2 commits into from
Mar 31, 2021

Conversation

skjiisa
Copy link
Contributor

@skjiisa skjiisa commented Mar 31, 2021

Instead of having an animation when you're dragging, have the animation only when you stop dragging.

@Jake-Short Jake-Short added the enhancement New feature or request label Mar 31, 2021
@Jake-Short
Copy link
Owner

Thanks @isvvc , this PR looks good! Only thing that is holding me back from merging right now is that ending the drag now causes the image to kind of abruptly stop, then fade out, rather than continue to move while fading out and slowing down.

If you wanted to try and workaround this you can, if not I can try and get to it soon and merge your request.

Thanks for your contribution :)

@skjiisa
Copy link
Contributor Author

skjiisa commented Mar 31, 2021

This should fix it. I used interactive spring for returning to rest position and regular spring for the fade out, but you could change those if you prefer something else.

@Jake-Short Jake-Short merged commit 87a7a1d into Jake-Short:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants